Conversation
- register happy-dom via bunfig preload; add bun-types to tsconfig - update renamed useThrottle import to useDebounce in apps/web - format dates as en-AU D/MM/YYYY - apply aria-label to icon-only Button (WCAG 4.1.2) - use atomic sort state to remove DataTable stale closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test && tsc --noEmitgreen (13 pass / 0 fail, tsc clean). No test files modified, no dependencies added.environment = "happy-dom"isn't a valid Bun key; replaced withpreloadof the existingpackages/ui/test/setup.ts(happy-dom GlobalRegistrator).types: ["bun-types"](already installed) to resolvebun:test.useThrottle→useDebounce(renamed export); publicuseSearchDebouncealias preserved.D/MM/YYYYviaformatToPartswith unpadded day (ICU en-AU pads day, soday: numericalone isn't enough).aria-label(explicit → string children → "Button" fallback + dev warning).Assumptions / follow-ups
aria-label.testscript's--preloadis now redundant with bunfig (harmless).