Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/src/lib/api.ts: update the staleuseThrottleimport to the renameduseDebounceexport from@e2e/utils.packages/uiButton: applyaria-labelto the<button>; icon-only buttons always get an accessible name (caller label → string child → generic"Button"fallback with a dev-only warning).packages/uiDataTable: fix a stale closure in sort toggling by using the functionalsetSortDir(prev => ...).packages/utilsformatDate: keep en-AU day-first order but drop the leading zero on the day (1/03/2024).bunfig.toml: preload the existing happy-dom setup. Bun has noenvironmentoption, so runningbun testdirectly failed withdocument is not defined.tsconfig.json: addtypes: ["bun-types"](already installed) sobun:testresolves.Verification
bun testpasses 13/13 andtsc --noEmitreports no errors.Assumptions / notes
aria-labeleven when the caller passes none, so the component falls back to the generic"Button". Screen-reader users get little from that name, so callers should pass a real label; the dev warning is there to prompt them.formatDatenow gives1/03/2024(day unpadded, month padded).formatDateTimestill gives1/3/24and was left as is because no failing test covers it.