Conversation
- apps/web: import renamed useDebounce hook (was useThrottle) - ui/Button: ensure icon-only buttons get an aria-label - ui/DataTable: use functional state update to fix stale closure in sort toggle - utils/formatDate: en-AU day-first format without leading zero on day - bunfig.toml: preload happy-dom global registrator so DOM tests run - tsconfig: include bun-types so bun:test resolves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
bun test && tsc --noEmitpass (13/13 tests, tsc exit 0). Before this, 9 of 13 tests failed.useDebounce. The hook had been renamed inpackages/utilsbutuseThrottlewas still imported here.aria-label, with a fallback label and a dev-mode warning when none is given.setSortDir(prev => ...)).1/03/2024).formatDateTimenow builds onformatDate.@happy-dom/global-registrator, which was already a dependency. The oldenvironmentkey was being ignored, so DOM tests failed.types: [bun-types]sobun:testresolves.Assumptions / notes
formatDateTimechange isn't covered by any test and changes its output (1/3/24, 12:00 pm→1/03/2024, 12:00 pm). It can be reverted for strict scope.aria-label, so a type-level requirement isn't possible. The runtime fallback is used instead.package.json's test script also passes--preload. The duplicate is harmless for now.