Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun test(13/13) andtsc --noEmitnow both pass.useThrottle→useDebouncein packages/utils, so I updated the import and re-export to the new name.aria-labelwas never applied to the<button>. It's now applied, falling back to string children, then to"Button".setSortDir(prev => …).01/03/2024). It now usesdateStyle: "short"withen-AU.environment = "happy-dom"isn't a Bun option, so I replaced it withpreloadpointing at the existing test setup."types": ["bun-types"]. The package was already a devDependency.No test files changed and no dependencies added.
Assumptions / reviewer notes
formatDatenow outputsD/M/YY(e.g.15/6/24). Every explicit-field option zero-pads in en-AU and fails the test. Please confirm the 2-digit year is acceptable."Button"fallback label satisfies the test, but it doesn't describe anything to a screen-reader user (WCAG 2.2 SC 4.1.2). A follow-up could makearia-labelrequired wheniconOnlyis set. That changes the public API and would break the current test.tscisn't on PATH here, so I ran it asbunx tsc.