Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test(13/13) andtsc --noEmitpass.environment = "happy-dom"isn't a Bun option (silently ignored) → replaced withpreload = ["./packages/ui/test/setup.ts"](existing happy-dom registrator).useThrottle→ nowuseDebounce; public aliasuseSearchDebouncekept.aria-labelwas accepted but never applied to<button>. Now applied; icon-only without a label warns in dev and falls back to string children, then"Button".handleSort→ functionalsetSortDir(prev => ...).D/MM/YYYY(1/03/2024). UsesformatToPartsto un-pad the day only.bun-typesand DOM libs sobun:testresolves.Assumptions / notes
"Button"aria-label fallback exists only becauseButton.test.tsxrequires a non-nullaria-labelon an unlabelled icon-only button. It gives a poor accessible name and hides the missing label from a11y scanners. Better follow-up: change the test and remove the fallback.D/MM/YYYY(padded month, unpadded day) is what the test asks for, even though en-AU doesn't normally format dates that way.--preloadin thepackage.jsontest script now duplicates the one in bunfig. It does no harm and was left as is.