Conversation
…nd missing import Implement paginate per its contract, align User.username across packages, fix POST never matching the public-method allow-list, add missing badRequest import, and wire existing bun-types into tsconfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/api/src/middleware/auth.ts): public-method allow-list had"post";c.req.methodis uppercase so POST was rejected with 401. Changed to"POST".packages/shared/src/types.ts):userName→usernameto match db, routes, and tests (fixed 6 type errors).packages/shared/src/utils/pagination.ts): implemented thepaginatestub (1-indexed pages,totalPages = ceil(total/size), empty slice for out-of-range pages).packages/api/src/routes/users.ts): added missingbadRequestimport (was causing a 500 instead of 400)."types": ["bun-types"]— already a devDependency, just not wired in (fixedbun:test/processtype errors).Verification
bun test: 22 pass / 0 failnode_modules/.bin/tsc --noEmit: clean (tscis not on global PATH)Assumptions / notes
auth.test.tsboth require it. Whether that policy is right for production is a separate question for the API owner.paginateclamps page/size to >= 1. Non-numeric input (NaN) is not handled because no test covers it.requireFieldsmiddleware invalidate.tsis never used. Left as is because it's outside the scope of this fix.