Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/api/src/middleware/auth.ts): the public-method allow-list had"post"in lowercase, so POST never matched and returned 401. It's now"POST", and the incoming method is normalised with.toUpperCase().packages/shared/src/types.ts): renamedUser.userNametousernameso it matchesdb.ts, the routes and the tests.packages/api/src/routes/users.ts): added the missingbadRequestimport. Without it the handler threw a ReferenceError and returned 500 instead of 400.packages/shared/src/utils/pagination.ts): implemented thepaginatestub to match the test contract. An empty array givestotalPages: 0, and a page past the end gives emptydata."types": ["bun-types"]sotsccan resolvebun:testandprocess.bun-typeswas already a devDependency, so nothing new is installed.Verification
bun test: 22 pass, 0 failnode_modules/.bin/tsc --noEmit: cleanAssumptions / notes
auth.test.tsasserts it. It still means anyone can create records without a token, which is worth revisiting before this is used for real.tscisn't on PATH in this environment, so the typecheck was run vianode_modules/.bin/tsc.