Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: implement paginate stub; align shared User type to
username; import missingbadRequestin users route; fix auth middleware method case-sensitivity; wire bun-types into tsconfig.Auth middleware was also hardened: it now requires the Bearer prefix, rejects requests when
API_TOKENis unset instead of using a hardcoded fallback, and compares tokens in constant time. This goes beyond what the tests require; revert those parts if you want a minimal diff.Result:
bun test && tsc --noEmit: 22 pass, 0 fail, tsc clean.Assumptions: the tests are correct, so
usernameis the right field name. No test files were changed and no dependencies were added.