Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all failing tests and tsc errors: auth method case normalisation (toUpperCase; lowercase delete/put still require a token), User.userName renamed to username in shared types, fixed missing badRequest in users route, implemented paginate() (size clamped to >=1), wired the already-installed bun-types in tsconfig (no new deps). Result: bun test 22/22 pass, tsc --noEmit clean.
Assumptions: the tests define the correct behaviour (including allowing unauthenticated POST). Found but left unchanged because this repo is a test fixture: a hardcoded token fallback ("test-token" when API_TOKEN is unset), a loosely checked Bearer prefix, a public GET /users that returns every user's email, and weak input validation.