Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paginate()stub per test contract (empty array →totalPages: 0, out-of-range page → empty data).User.userName→usernameto match API routes/db/tests."post"instead of"POST"; fixed and normalisedc.req.method.toUpperCase()defensively.badRequestimport (ReferenceError on invalid POST)."types": ["bun-types"](already a devDependency) so test files typecheck.Results
bun test: 22 pass / 0 fail (was 13/22).bunx tsc --noEmit: 0 errors (was 14).tscis not on PATH, sobunx tscwas used.Assumptions
Follow-ups (out of scope)
auth.tsfalls back to a hardcoded"test-token"whenAPI_TOKENis unset and uses a non-constant-time compare; should fail closed and usetimingSafeEqual.paginate(items, page, 0)yieldstotalPages: Infinity; no production callers currently.