Conversation
- calculator.divide: guard against division by zero - string-utils.wordCount: handle consecutive whitespace via /\s+/ - string-utils.truncate: implement word-boundary truncation with ellipsis - task-manager: implement remove, update, sortBy - date-utils.diffDays: fix off-by-one (Math.round instead of Math.floor) - validator.isEmail: accept subdomains and long TLDs - validator.isUrl: accept URLs with explicit ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. Suite now: 60 pass, 0 fail. No test files modified, no dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/string-utils.tswordCounttrims and splits on/\s+/(was counting empty strings from consecutive spaces →"hello world"returned 3, now 2).truncateimplemented: unchanged whenlength <= maxLength; otherwise reserves 3 chars for"...", backs off to the last word boundary.src/task-manager.ts— implementedremove(Map.delete),update(partial, undefined-safe field application), andsortBy(priority/status rank maps, numericcreatedAt).src/date-utils.ts—diffDaysusesMath.roundinstead ofMath.floor(off-by-one: 36h now reads "2 days ago").src/validator.ts—isEmailaccepts subdomains and long TLDs (e.g..museum);isUrlaccepts explicit ports (http://localhost:3000) while still allowlistinghttp/https.Verification
bun test→ 60 pass, 0 fail (70 expect() calls).tsc --noEmit→ clean.Assumptions & notes
truncatepotentially splitting a surrogate pair;sortBylacking adefaultreturn for untyped JS callers). These are not exercised by the test suite and were left unchanged to keep the diff scoped — worth a follow-up if hardening is desired.