Conversation
- calculator: divide throws on zero divisor - date-utils: round day diff in formatRelative - string-utils: fix wordCount whitespace handling, implement truncate - validator: accept long TLDs/subdomains in isEmail, ports in isUrl - task-manager: implement remove, update, sortBy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculator.dividethrows on division by zerodate-utils.formatRelativeuses rounding for day buckets (36h → 2 days ago)string-utils:wordCountsplits on/\s+/;truncateimplemented (word-boundary, ellipsis counts toward maxLength)validator:isEmailaccepts subdomains and long TLDs;isUrlaccepts explicit portsTaskManager:remove,update,sortByimplementedVerification
bun test: 60 pass / 0 fail (was 44 / 16)bunx tsc --noEmit: cleanAssumptions
sortBy('status')ordering (in_progress > pending > completed) isn't covered by tests; chosen as a reasonable default.truncatewithmaxLength <= 3hard-cuts without an ellipsis.Follow-ups (not in scope)
formatRelativecan show "24 hours ago` for 23.5–23.99h.