Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes
bun testfrom 44 passing / 16 failing to 60 passing / 0 failing.tsc --noEmitpasses. No test files were changed and no dependencies were added.dividenow throws on division by zero instead of returningInfinity.wordCountnow splits on any run of whitespace.truncateis now implemented: it cuts at a word boundary, appends..., and never goes overmaxLength.remove,updateandsortByare now implemented.sortBysorts a copy, so the stored tasks keep their order.formatRelativenow usesMath.roundfor days, the same as it does for minutes and hours.isEmailnow accepts TLDs longer than 4 characters.isUrlnow accepts URLs that include a port.Assumptions / notes
dividecan now throw, which is a breaking change for any caller that expectedInfinity. Nothing in this repo relies on the old behaviour.isEmailis still a loose format check, not full RFC 5322 validation.