Skip to content
This repository was archived by the owner on May 11, 2023. It is now read-only.

Replace colored_json with json-color - #229

Merged
cloudhead merged 1 commit into
radicle-dev:masterfrom
pinkforest:switch/json/colorizer
Aug 30, 2022
Merged

Replace colored_json with json-color#229
cloudhead merged 1 commit into
radicle-dev:masterfrom
pinkforest:switch/json/colorizer

Conversation

@pinkforest

@pinkforest pinkforest commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Miss M MissM_signed@protonmail.ch

Taking initial cheap shot at it - replacing with equally not-active crate

Bonus: one less dependency to ansi_term - this uses colored crate instead

json-color dependency tree:

color v0.1.0 (/home/radicle/play/color)
└── json-color v0.7.1
    ├── colored v1.9.3
    │   ├── atty v0.2.14
    │   │   └── libc v0.2.132
    │   └── lazy_static v1.4.0
    ├── serde v1.0.144
    └── serde_json v1.0.85
        ├── indexmap v1.9.1
        │   └── hashbrown v0.12.3
        │   [build-dependencies]
        │   └── autocfg v1.1.0
        ├── itoa v1.0.3
        ├── ryu v1.0.11
        └── serde v1.0.144

erak
erak previously approved these changes Aug 26, 2022

@erak erak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Maybe it would have be good to mention in this PR that the reason for the switch is the licensing issue.

Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
@cloudhead
cloudhead force-pushed the switch/json/colorizer branch from 2916e60 to 6462fe5 Compare August 30, 2022 08:18
@cloudhead
cloudhead merged commit 6462fe5 into radicle-dev:master Aug 30, 2022
@pinkforest
pinkforest deleted the switch/json/colorizer branch August 30, 2022 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants