This repository was archived by the owner on May 11, 2023. It is now read-only.
Replace colored_json with json-color - #229
Merged
Merged
Conversation
erak
previously approved these changes
Aug 26, 2022
erak
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 Maybe it would have be good to mention in this PR that the reason for the switch is the licensing issue.
cloudhead
force-pushed
the
switch/json/colorizer
branch
from
August 30, 2022 08:17
d260440 to
2916e60
Compare
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
cloudhead
force-pushed
the
switch/json/colorizer
branch
from
August 30, 2022 08:18
2916e60 to
6462fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miss M MissM_signed@protonmail.ch
Taking initial cheap shot at it - replacing with equally not-active crate
Bonus: one less dependency to ansi_term - this uses colored crate instead
json-color dependency tree: