This repository was archived by the owner on May 11, 2023. It is now read-only.
Bump Chrono to 0.4.22 and remove time 0.1 - #231
Merged
Conversation
cloudhead
previously approved these changes
Aug 30, 2022
cloudhead
left a comment
Contributor
There was a problem hiding this comment.
Nothing better than getting rid of dependencies
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
cloudhead
force-pushed
the
bump/chrono-and-time
branch
from
August 30, 2022 08:20
224a8a8 to
3705500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miss M MissM_signed@protonmail.ch
This PR resolves two below security advisories:
RUSTSEC-2020-0159, RUSTSEC-2020-0071 - When doing env & time same time - it's not thread safe
Chrono from 0.4.20 has a new maintainer and did a lot of fixes including RiR localtime_r 🥳
time 0.1 in turn is brought by chrono "oldtime" feature that is "optional" (but default) chrono dependency
default = ["clock", "std", "oldtime", "wasmbind"]->oldtime = ["time"]But time 0.1 was included via common & inspect as chrono was imported with default features
I've set the features explicitly leaving out
oldtimethat is not considered thread safe andwasmbindwe don't need eitherBy specifying the feature explicitly we got rid of time 0.1 🥳
Then I had also - in order to bump the .lock more precisely for chrono 0.4.22 do:
$ cargo update -p chrono
libc was holding back chrono bump to 0.4.22 so:
$ cargo update -p libc
$ cargo update -p chrono --precise 0.4.22