Skip to content

deploy: always sign with PRIVATE_KEY (never PRIVATE_KEY_DEV) #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 4 commits into from
Jun 5, 2026
Merged

deploy: always sign with PRIVATE_KEY (never PRIVATE_KEY_DEV) #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33661a7
deploy: always sign with PRIVATE_KEY (never PRIVATE_KEY_DEV)
thedavidmeister Jun 5, 2026
e97b760
ci: modernize nix setup (drop dead magic-nix-cache, add cachix + cach…
thedavidmeister Jun 5, 2026
e424c53
test: fix Flow.time.t.sol generateFlowStack calls (missed in the Flow…
thedavidmeister Jun 5, 2026
9d47b64
test: forge fmt Flow.time.t.sol
thedavidmeister Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/manual-sol-artifacts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
deploy:
runs-on: ubuntu-latest
env:
DEPLOYMENT_KEY: ${{ github.ref == 'refs/heads/main' && secrets.PRIVATE_KEY || secrets.PRIVATE_KEY_DEV }}
DEPLOYMENT_KEY: ${{ secrets.PRIVATE_KEY }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
22 changes: 18 additions & 4 deletions .github/workflows/rainix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,30 @@ jobs:
fail-fast: false
runs-on: ${{ matrix.os }}
env:
DEPLOYMENT_KEY: ${{ github.ref == 'refs/heads/main' && secrets.PRIVATE_KEY || secrets.PRIVATE_KEY_DEV }}
DEPLOYMENT_KEY: ${{ secrets.PRIVATE_KEY }}
steps:
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 0

- name: Install Nix
uses: DeterminateSystems/nix-installer-action@v4
- uses: DeterminateSystems/magic-nix-cache-action@v2
- uses: nixbuild/nix-quick-install-action@v30
with:
nix_conf: |
keep-env-derivations = true
keep-outputs = true
- uses: cachix/cachix-action@v15
continue-on-error: true
with:
name: rainlanguage
authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
useDaemon: false
- name: Restore and save Nix store
uses: nix-community/cache-nix-action@v6
with:
primary-key: nix-${{ runner.os }}-${{ hashFiles('**/*.nix', '**/flake.lock') }}
restore-prefixes-first-match: nix-${{ runner.os }}-
gc-max-store-size-linux: 1G

- run: nix develop --command rainix-sol-prelude

Expand Down
6 changes: 4 additions & 2 deletions test/src/concrete/Flow.time.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ contract FlowTimeTest is FlowTest {
function testFlowBasicFlowTimeNoStoreSetWhenKvsEmpty() public {
(IFlowV5 flow, EvaluableV2 memory evaluable) = deployFlow();

uint256[] memory stack = generateFlowStack(transferEmpty());
uint256[] memory stack =
LibStackGeneration.generateFlowStack(Sentinel.unwrap(RAIN_FLOW_SENTINEL), transferEmpty());
interpreterEval2MockCall(stack, new uint256[](0));

// Mock set to a no-op so the existing REVERTING_MOCK_BYTECODE on
Expand All @@ -56,7 +57,8 @@ contract FlowTimeTest is FlowTest {

(IFlowV5 flow, EvaluableV2 memory evaluable) = deployFlow();

uint256[] memory stack = generateFlowStack(transferEmpty());
uint256[] memory stack =
LibStackGeneration.generateFlowStack(Sentinel.unwrap(RAIN_FLOW_SENTINEL), transferEmpty());
interpreterEval2MockCall(stack, writeToStore);

vm.mockCallRevert(address(STORE), abi.encodeWithSelector(IInterpreterStoreV2.set.selector), "STORE_SET_FAILED");
Expand Down
Loading