Skip to content

Seed suiteNames's named return before the loop #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thedavidmeister wants to merge 1 commit into from
Closed

Seed suiteNames's named return before the loop #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/abstract/RainDeploySuitesBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ abstract contract RainDeploySuitesBase {
/// @return names The declared keys.
function suiteNames() internal pure returns (string memory names) {
DeploySuite[] memory suites = allSuites();
// Seeded here so every path out of this function assigns `names`,
// provable from this body alone. `allSuites` never yields an empty set,
// but that is a fact about another function.
names = "";
for (uint256 i = 0; i < suites.length; i++) {
names = i == 0 ? suites[i].suite : string.concat(names, ", ", suites[i].suite);
}
Expand Down
Loading