Skip to content

.soldeerignore carries entries for .vscode and /docs, paths that have never existed in this repo #91

Description

@thedavidmeister

Audit scope: whole-repo, commit 7aa85a4

Recovered from the docs/process/CI reviewer's report (its finding Q3); dimension 4 (code quality), severity low.

Where

.soldeerignore:8, 12

Problem

.vscode (line 8) and /docs (line 12) match nothing and never have. They are inherited from another repo's ignore list.

Dead entries in an exclusion list are worse than dead code elsewhere: the list's whole job is to be read as "this is what the package excludes". Entries that exclude nothing make a reader assume the list was derived from the package contents rather than copied, which is exactly the assumption that let the shipped-script/-with-a-/test-import problem through (see #76).

Measured

  • git log --all -- docs — empty.
  • git log --all -- .vscode — empty.

Neither path has ever been in this repo.

Proposed fix

Delete lines 8 and 12.

Keep .DS_Store (line 1). It is a defensive entry for a file that is never committed but can exist in a working tree at publish time, which is a different case from a path the repo has no concept of.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

auditAudit findinglowAudit findingpass4Audit finding

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions