Skip to content

background tx processing and Otel logging #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rouzwelt merged 13 commits into from
Nov 25, 2025
Merged

background tx processing and Otel logging #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f2b9b1d
init
rouzwelt Nov 14, 2025
045eb55
fixes
rouzwelt Nov 14, 2025
63cdbb1
typo
rouzwelt Nov 14, 2025
22a8ecc
Update transaction.ts
rouzwelt Nov 14, 2025
0945ca8
Update index.ts
rouzwelt Nov 14, 2025
74c8296
typo
rouzwelt Nov 14, 2025
4db99ce
typo
rouzwelt Nov 14, 2025
a62e9d4
Update types.ts
rouzwelt Nov 14, 2025
837e651
fix
rouzwelt Nov 14, 2025
a494c3a
update
rouzwelt Nov 14, 2025
9fd7313
update
rouzwelt Nov 14, 2025
3c2a1e5
update
rouzwelt Nov 14, 2025
b787bbe
update base e2e test block number
rouzwelt Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 106 additions & 53 deletions src/core/process/order.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe("Test processOrder", () => {
takeOrder: {
id: "0xid",
quote: { maxOutput: 1000000000000000000n, ratio: 2000000000000000000n },
takeOrder: {},
struct: { order: { owner: "0xowner" } },
},
},
signer: {},
Expand Down Expand Up @@ -107,8 +107,11 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.order"]).toEqual("0xid");
expect(result.value.spanAttributes["details.pair"]).toBe("BUY/SELL");
expect(result.value.spanAttributes["details.orderbook"]).toEqual("0xorderbook");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
expect(result.value.endTime).toBeTypeOf("number");

// ensure pair maps are updated on quote 0
Expand Down Expand Up @@ -136,8 +139,11 @@ describe("Test processOrder", () => {
expect(result.error.spanAttributes["details.pair"]).toBe("BUY/SELL");
expect(result.error.spanAttributes["details.orderbook"]).toEqual("0xorderbook");
expect(result.error.endTime).toBeTypeOf("number");
expect(result.error.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.error.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.error.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.error.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});

// ensure pair maps are updated on quote failure
expect(mockOrderManager.removeFromPairMaps).toHaveBeenCalledWith(mockArgs.orderDetails);
Expand Down Expand Up @@ -172,16 +178,23 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.inputToEthPrice"]).toBe("100");
expect(result.value.spanAttributes["details.outputToEthPrice"]).toBe("no-way");
expect(result.value.endTime).toBeTypeOf("number");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getEthMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getEthMarketPrice"]).toHaveLength(2);
expect(result.value.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getEthMarketPrice"]).toBeGreaterThan(0);
expect(result.value.spanEvents["getEthMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it('should set outputToEthPrice to "0" if getMarketPrice returns undefined for output and gasCoveragePercentage is "0"', async () => {
Expand Down Expand Up @@ -213,16 +226,23 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.inputToEthPrice"]).toBe("100");
expect(result.value.spanAttributes["details.outputToEthPrice"]).toBe("0");
expect(result.value.endTime).toBeTypeOf("number");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getEthMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getEthMarketPrice"]).toHaveLength(2);
expect(result.value.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getEthMarketPrice"]).toBeGreaterThan(0);
expect(result.value.spanEvents["getEthMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it('should return FailedToGetEthPrice if getMarketPrice returns undefined and gasCoveragePercentage is not "0"', async () => {
Expand All @@ -248,12 +268,18 @@ describe("Test processOrder", () => {
expect(result.error.spanAttributes["details.pair"]).toBe("BUY/SELL");
expect(result.error.spanAttributes["details.orderbook"]).toEqual("0xorderbook");
expect(result.error.endTime).toBeTypeOf("number");
expect(result.error.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.error.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.error.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
expect(result.error.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.error.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.error.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.error.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.error.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it('should set input/outputToEthPrice to "0" if getMarketPrice returns undefined and gasCoveragePercentage is "0"', async () => {
Expand Down Expand Up @@ -281,16 +307,23 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.pair"]).toBe("BUY/SELL");
expect(result.value.spanAttributes["details.orderbook"]).toEqual("0xorderbook");
expect(result.value.endTime).toBeTypeOf("number");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getEthMarketPrice"]).toBeGreaterThan(
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getEthMarketPrice"]).toHaveLength(2);
expect(result.value.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getEthMarketPrice"]).toBeGreaterThan(0);
expect(result.value.spanEvents["getEthMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it("should return ok result if findBestTrade throws with noneNodeError", async () => {
Expand Down Expand Up @@ -323,18 +356,28 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.noneNodeError"]).toBe(true);
expect(result.value.spanAttributes["details.test"]).toBe("something");
expect(result.value.endTime).toBeTypeOf("number");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getEthMarketPrice"]).toBeGreaterThan(
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getEthMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.findBestTrade"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.findBestTrade"]).toHaveLength(2);
expect(result.value.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getEthMarketPrice"]).toBeGreaterThan(0);
expect(result.value.spanEvents["getEthMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.findBestTrade"]).toBeGreaterThan(0);
expect(result.value.spanEvents["findBestTrade"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it("should return ok result if findBestTrade throws without noneNodeError", async () => {
Expand Down Expand Up @@ -367,18 +410,28 @@ describe("Test processOrder", () => {
expect(result.value.spanAttributes["details.noneNodeError"]).toBe(false);
expect(result.value.spanAttributes["details.test"]).toBe("something");
expect(result.value.endTime).toBeTypeOf("number");
expect(result.value.spanAttributes["details.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.quoteOrder"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getPairMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.getEthMarketPrice"]).toBeGreaterThan(
expect(result.value.spanAttributes["events.duration.quoteOrder"]).toBeGreaterThan(0);
expect(result.value.spanEvents["quoteOrder"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getPairMarketPrice"]).toBeGreaterThan(
0,
);
expect(result.value.spanAttributes["event.getEthMarketPrice"]).toHaveLength(2);
expect(result.value.spanAttributes["details.duration.findBestTrade"]).toBeGreaterThan(0);
expect(result.value.spanAttributes["event.findBestTrade"]).toHaveLength(2);
expect(result.value.spanEvents["getPairMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.getEthMarketPrice"]).toBeGreaterThan(0);
expect(result.value.spanEvents["getEthMarketPrice"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
expect(result.value.spanAttributes["events.duration.findBestTrade"]).toBeGreaterThan(0);
expect(result.value.spanEvents["findBestTrade"]).toEqual({
startTime: expect.any(Number),
duration: expect.any(Number),
});
});

it("should proceed to processTransaction if all steps succeed (happy path)", async () => {
Expand Down
Loading
Loading