Skip to content

[AUD-015] [LOW] Bare src/ import paths across the test tree break compilation under soldeer/submodule consumption #85

Description

@thedavidmeister

Whole-repo audit 2026-08-24 at commit 3e76bab (audit skill 0.35.0). Pass 2 status: ledgered (audit/mutation-test-scans.json, scan of 2026-08-24T08:55:39Z at 35496d8).

test/src/lib/mut/LibConformString.t.sol:8-11

Bare first-party src//test/ import paths in the test tree break compilation whenever the repo is consumed as a git submodule or soldeer dependency (the consumer's own src/ shadows the paths). Complete enumeration — src/ has ZERO bare imports and no script/ dir exists; all 16 occurrences are in 7 test-tree files: test/src/lib/mut/LibConformString.t.sol:8,9,10,11 (src/ x4); test/src/lib/parse/LibParseChar.skipMask.t.sol:7 (src/), :10 (test/); test/src/lib/parse/LibParseChar.isMask.t.sol:7 (src/), :10 (test/); test/src/lib/parse/LibParseDecimal.unsafeDecimalStringToInt.t.sol:8 (src/), :9 (test/), :15 (src/); test/src/lib/parse/LibParseDecimal.unsafeDecimalStringToSignedInt.t.sol:8 (src/), :14 (src/); test/src/lib/parse/LibParseCMask.t.sol:174,175 (src/ x2); test/lib/parse/LibParseDecimalSlow.sol:5 (src/). remappings.txt maps only the three dependencies, so these resolve via ambient project-root resolution only.

Proposed fix

Rewrite all 16 to relative paths. Files at test/src/lib/{mut,parse}/ are 4 levels deep: from "src/X" -> from "../../../../src/X" and from "test/lib/parse/Y" -> from "../../../lib/parse/Y". test/lib/parse/LibParseDecimalSlow.sol:5 is 3 levels deep: from "src/error/ErrParse.sol" -> from "../../../src/error/ErrParse.sol". E.g. LibParseChar.skipMask.t.sol:7 import {LibParseChar} from "../../../../src/lib/parse/LibParseChar.sol"; and :10 import {LibParseCharSlow} from "../../../lib/parse/LibParseCharSlow.sol";. Fix must cover all 16 in one pass — a partial fix leaves the category unresolved.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

auditAudit findinglowAudit findingpass4Audit finding

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions