copy-artifacts: regenerate meta via consumer-provided build-meta.sh hook - #208
Conversation
Add a `script/build-meta.sh` hook step between soldeer install and BuildPointers so the reusable currency-checks committed authoring-meta artifacts the same way it checks pointers and abis. The script is consumer-provided because rain meta build's invocation (input/output filenames, meta type) varies per repo. Without this, consumers needed a bespoke git-clean workflow to catch stale meta files; this lets them drop it. Resolves #207. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow ChangesMeta Artifact Regeneration Workflow
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=S |
Summary
script/build-meta.shhook step torainix-copy-artifacts.yaml(if: hashFiles(...) != ''), running between soldeer install andBuildPointers.solvia#sol-shell, so the reusable currency-checks committed authoring-meta artifacts the same way it already checks pointers and ABIs.rain meta build's invocation (input/output filenames, meta type) varies per repo — same shape as the existingBuildPointers.sol/CopyArtifacts.solhooks.Resolves #207. Once this lands, raindex#2600 can resolve by dropping its bespoke
git-cleanworkflow (its only unique coverage was meta currency).Test plan
build-meta.sh, so the new step is a no-op there — verifies theif: hashFiles(...)guard works and nothing regresses).copy-artifacts.yamlat this branch with an addedscript/build-meta.sh; expect green on raindex CI.🤖 Generated with Claude Code
Summary by CodeRabbit