fix: replace LICENSE symlink with real DCL-1.0 file (unblocks consumer deploys) - #232
Conversation
…ocks consumer deploys) The repo-root /LICENSE is a git symlink (mode 120000) whose target was LICENSES/DCL-1.0.txt, which does not exist. The real license file follows REUSE/SPDX naming: LICENSES/LicenseRef-DCL-1.0.txt. The dangling symlink causes GitHub Actions action-staging to fail with "Could not find file .../LICENSE" whenever a consumer downloads a rainix composite action (e.g. raindex deploy via rainix-manual-sol-artifacts.yaml -> nix-cachix-setup -> checkout). Introduced by 104cfe6 (2024-12-03 typo), only surfaced now that the deploy reusable routes through the composite actions. Repoint the symlink at the real LICENSES/ file (keeping the REUSE convention symlink) so it resolves again, unblocking raindex and all downstream consumer deploys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe ChangesLicense Reference Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The root LICENSE is a regular file containing the DecentraLicense 1.0 text (identical to LICENSES/LicenseRef-DCL-1.0.txt), matching every other rain repo whose root LICENSE is a real 17901-byte file. This removes the symlink that broke when consumers staged rainix without preserving symlink targets. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The root LICENSE symlink targeted LICENSES/DCL-1.0.txt, which does not exist; the license file is LICENSES/LicenseRef-DCL-1.0.txt (SPDX REUSE naming). The broken symlink fails GitHub Actions action-staging for consumers that download rainix composite actions (e.g. raindex deploy via the manual-sol-artifacts reusable). Keep LICENSE a symlink, repointed to the real file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed 7843c89: repoints the broken root LICENSE symlink to the real LICENSES/LicenseRef-DCL-1.0.txt. The only license-relevant check, |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=S |
The bug
The repo-root
/LICENSEis a git symlink (mode120000) whose target isLICENSES/DCL-1.0.txt— which does not exist. The actual license file follows REUSE/SPDX naming:LICENSES/LicenseRef-DCL-1.0.txt.This dangling symlink causes GitHub Actions action-staging to fail with:
whenever a consumer downloads a rainix composite action (e.g. raindex's deploy via
rainix-manual-sol-artifacts.yaml->nix-cachix-setup->checkout). When Actions stages a composite action, it materializes every tracked file including symlinks; a symlink with a non-existent target can't be staged, so the whole action download fails.The fix
Replace the root
/LICENSEsymlink with a real regular file (mode100644) containing the DecentraLicense 1.0 text, identical toLICENSES/LicenseRef-DCL-1.0.txt.This matches the org-wide convention: every other rain repo (raindex, rain.metadata, rain.math.float, rain.interpreter.interface, rain.lib.memkv, rain.string, rain.factory, rain.extrospection) ships its root
LICENSEas a real 17901-byte DecentraLicense file, not a symlink. rainix was the only repo using a symlink.git ls-files -s LICENSE→ mode100644(regular file, not120000).LICENSES/LicenseRef-DCL-1.0.txt(17901 bytes), which matches raindex's and rain.metadata's rootLICENSEexactly.find . -xtype lis empty).Impact
Unblocks raindex (and all downstream consumer) deploys that pull rainix composite actions.
Summary by CodeRabbit