ci: prefer the Binance dataseed over publicnode for BSC fork RPC - #375
Conversation
publicnode's BSC pool passed the preflight and then served `block not found` for a head it had itself just reported — a load balancer whose backends disagree on the tip — which took down rain.deploy#161's fork test. The dataseed leads the default order; both remain candidates. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiqQdxokJ4edjAFyAkN9G3
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe BSC network default endpoint order now prefers ChangesBSC RPC preflight
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to BSC preflight now selects the Binance dataseed before publicnode while retaining publicnode as a fallback. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
#375 reordered the BSC defaults inside the preflight binary, which consumers run at the pinned revision. Same 13-file bump. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiqQdxokJ4edjAFyAkN9G3

publicnode's BSC pool passed the preflight and then served
block not foundfor a head it had itself just reported — a load balancer whosebackends disagree on the tip — which took down rain.deploy#161's fork
test. The dataseed leads the default order; both remain candidates.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01HiqQdxokJ4edjAFyAkN9G3
Summary by CodeRabbit