chore: apply pre-commit formatting to main - #139
Conversation
Exactly what `pre-commit run --all-files` writes on unmodified main: no hand edits. `denofmt` rewraps `README.md` and `CLAUDE.md` to 80 columns and adds the missing trailing newline to `README.md`. `yamlfmt` drops the blank line before `jobs:` in `.github/workflows/pr-assessment.yaml`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
pre-commit run --all-filesfails on unmodifiedmain. This commits exactly what the hooks write, nothing else.QA
pre-commit run --all-filesingithub:rainlanguage/rainix/8657b83b68f41957ab85da91132c3f652c1f32c0#sol-shell. Fails on base: exit 1,denofmtandyamlfmtboth report "files were modified by this hook", three files dirty. Passes here: exit 0, clean tree.pre-commit run --all-filestwice more after the commit, both clean with the tree unmodified.deno fmtandyamlfmtdecide the content, not me, invoked exactly as the CI step invokes them. Second reader over the same bytes:agent-context-capclean at 3926 bytes against cap 4096.pre-commit run --all-filesonmainfrom exactly what the hooks write; covered.forge lint -D warningsis the other red gate and is deliberately not touched here.Why main has never been through this
rainix added
pre-commit run --all-filesto the sharedrainix-sol-staticworkflow at 2026-09-15T20:59Z.main's last run was 2026-09-15T17:16Z (#137), somainhas never been through the gate. On PR branches it is still invisible, because theforge lint -D warningsstep ahead of it fails first and the pre-commit step never runs.What the hooks write
denofmtrewrapsREADME.mdandCLAUDE.mdto 80 columns, and adds the trailing newlineREADME.mdwas missing.yamlfmtdrops the blank line beforejobs:in.github/workflows/pr-assessment.yaml.No hand editing. The commit is the hooks' own output.
Merge order
rainix-sol / staticrunsforge lintbeforepre-commit, andmainis red at both steps. Neither fix can be green on its own: this branch never reaches the pre-commit step because lint fails first, and #140 clears lint and then fails at pre-commit. Whichever lands first therefore merges withstaticred at the step the other PR fixes.This one goes first. Its
staticfailure is exactly the 37forge lintfindingsmainalready has, reproduced identically on an unmodifiedmainclone, and itstestandlegaljobs are green. #140 then rebases onto it and runs fully green before merging.Notes
The
CLAUDE.mdrewrap adds 20 bytes, 3906 to 3926, against the org agent-context cap of 4096. The check still passes, but the headroom is now 170 bytes.forge test: 128 passed across 17 suites either side, unchanged. This PR touches no Solidity.🤖 Generated with Claude Code
https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN