chain id op

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

• New Features

  • Enhanced chain identification is now fully integrated with improved precision and active metadata, ensuring a more reliable chain ID operation.

• Tests

  • Introduced comprehensive tests that verify runtime behavior, integrity checks, and error handling for chain identification.
  • Removed outdated testing suites to streamline overall test coverage.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• src/generated/RainterpreterExpressionDeployer.pointers.sol is excluded by !**/generated/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the chain ID operation integration across the library and its tests. In the core library files, the chain ID functionality has shifted from the deprecated LibOpChainIdNP to a new implementation in LibOpChainId. This makes adjustments to import statements, constants, and function signatures, including the use of new data types. Additionally, new test cases have been added while the old test contract for LibOpChainIdNP has been removed to reflect the updated chain ID operation behavior.

Changes

File(s)	Summary
src/lib/op/LibAllStandardOps.sol	Updated import from LibOpChainIdNP to LibOpChainId, increased ALL_STANDARD_OPS_LENGTH from 20 to 21, uncommented the AuthoringMetaV2 chain ID entry, and replaced commented integrity and run function pointers to use LibOpChainId.
src/lib/op/evm/LibOpChainId.sol	Renamed the library from LibOpChainIdNP to LibOpChainId; updated the referenceFn function signature to receive and return StackItem[] instead of uint256[]; added new imports (e.g., StackItem, Float, etc.) to support new math features.
test/src/lib/op/evm/LibOpChainId.t.sol	Introduced a new test contract LibOpChainIdTest with functions to validate the chain ID operation’s integrity, runtime execution, evaluation, and failure cases.
test/src/lib/op/evm/LibOpChainIdNP.t.sol	Removed the test contract LibOpChainIdNPTest that previously validated the deprecated library functionality.

Sequence Diagram(s)

sequenceDiagram
    participant T as Test Contract
    participant I as Interpreter
    participant L as LibOpChainId

    T->>I: Set up chain ID and prepare state
    I->>L: Invoke integrity() / run() of chain id operation
    L-->>I: Return chain ID wrapped in a StackItem
    I-->>T: Deliver processed output
    T->>T: Assert expected chain ID output

Loading

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.