Spell the pinned forge-std and rain-sol-codegen versions in every import - #577
Conversation
forge-std-1.16.1/ -> forge-std-1.16.2/ and rain-sol-codegen-0.1.0/ -> rain-sol-codegen-0.1.36/ across src, test and script, and the remappings block that aliased the older prefixes onto the installed packages is gone. An alias compiles a file against a version it does not name, so the versioned prefix stops being the pin, and every consumer of this package had to carry the same aliases to compile the shipped harness. Import paths only; the 0.1.36 tooling interfaces widen three functions from pure to view and the implementations here keep pure. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
|
Important Review skippedToo many files! This PR contains 125 files, which is 25 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (125)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Every import now spells the version
foundry.tomlpins:forge-std-1.16.1/->forge-std-1.16.2/andrain-sol-codegen-0.1.0/->rain-sol-codegen-0.1.36/acrosssrc,testandscript, and theremappingsblock that aliased the older prefixes onto the installed packages is gone.An alias makes a file compile against a version it does not name, so the versioned prefix stops being the pin. It also leaked downstream: every consumer of this package had to carry the same two aliases to compile the shipped
test/abstractharness and the tooling interfaces. With the package spelling what it pins, consumers pinforge-std1.16.2 andrain-sol-codegen0.1.36 and nothing else.No source change beyond import paths. The
rain-sol-codegen0.1.36 tooling interfaces widen three functions frompuretoview; the implementations here keeppure, which overrides narrow.script/Build.solregenerates the reference extern pointers byte-identically.QA
ARBITRUM_RPC_URLfork fixtures failing locally as onmain. The build itself is the discriminating check: with the alias block gone, any import still spelling a prefix that is not installed fails to resolve.foundry.toml[dependencies], which the imports now match one-to-one;forge remappingsshows no alias.🤖 Generated with Claude Code
https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq