Skip to content

Spell the pinned forge-std and rain-sol-codegen versions in every import - #577

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-09-07-spell-pinned-versions
Sep 7, 2026
Merged

thedavidmeister merged 1 commit into
mainfrom
2026-09-07-spell-pinned-versions

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Every import now spells the version foundry.toml pins: forge-std-1.16.1/ -> forge-std-1.16.2/ and rain-sol-codegen-0.1.0/ -> rain-sol-codegen-0.1.36/ across src, test and script, and the remappings block that aliased the older prefixes onto the installed packages is gone.

An alias makes a file compile against a version it does not name, so the versioned prefix stops being the pin. It also leaked downstream: every consumer of this package had to carry the same two aliases to compile the shipped test/abstract harness and the tooling interfaces. With the package spelling what it pins, consumers pin forge-std 1.16.2 and rain-sol-codegen 0.1.36 and nothing else.

No source change beyond import paths. The rain-sol-codegen 0.1.36 tooling interfaces widen three functions from pure to view; the implementations here keep pure, which overrides narrow. script/Build.sol regenerates the reference extern pointers byte-identically.

QA

  • Discriminating tests: the full suite, unchanged in count, with only the ARBITRUM_RPC_URL fork fixtures failing locally as on main. The build itself is the discriminating check: with the alias block gone, any import still spelling a prefix that is not installed fails to resolve.
  • Mutations applied: n/a, import paths only.
  • Oracle: foundry.toml [dependencies], which the imports now match one-to-one; forge remappings shows no alias.
  • Category check: the ruling "you can't remap versions" on rain.dia#72; this is the upstream fix it requires.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq

forge-std-1.16.1/ -> forge-std-1.16.2/ and rain-sol-codegen-0.1.0/ ->
rain-sol-codegen-0.1.36/ across src, test and script, and the
remappings block that aliased the older prefixes onto the installed
packages is gone. An alias compiles a file against a version it does
not name, so the versioned prefix stops being the pin, and every
consumer of this package had to carry the same aliases to compile the
shipped harness.

Import paths only; the 0.1.36 tooling interfaces widen three functions
from pure to view and the implementations here keep pure.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 125 files, which is 25 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: cb5b7f87-d666-4408-b447-4e5b4fe0219b

📥 Commits

Reviewing files that changed from the base of the PR and between 06ffe3c and 8956238.

📒 Files selected for processing (125)
  • foundry.toml
  • script/Build.sol
  • script/BuildAuthoringMeta.sol
  • src/abstract/BaseRainlangExpressionDeployer.sol
  • src/abstract/BaseRainlangExtern.sol
  • src/abstract/BaseRainlangInterpreter.sol
  • src/abstract/BaseRainlangParser.sol
  • src/abstract/BaseRainlangSubParser.sol
  • test/abstract/OpTest.sol
  • test/abstract/OperandTest.sol
  • test/abstract/ParseLiteralTest.sol
  • test/abstract/ParseTest.sol
  • test/abstract/RainlangExpressionDeployerDeploymentTest.sol
  • test/lib/deploy/LibTestInterpreterDeploy.sol
  • test/lib/string/LibCamelToKebab.t.sol
  • test/src/abstract/BaseRainlangExtern.construction.t.sol
  • test/src/abstract/BaseRainlangExtern.ierc165.t.sol
  • test/src/abstract/BaseRainlangExtern.integrityOpcodeRange.t.sol
  • test/src/abstract/BaseRainlangSubParser.ierc165.t.sol
  • test/src/abstract/BaseRainlangSubParser.subParseLiteral2.t.sol
  • test/src/abstract/BaseRainlangSubParser.subParseWord2.t.sol
  • test/src/concrete/Rainlang.ierc165.t.sol
  • test/src/concrete/RainlangExpressionDeployer.ierc165.t.sol
  • test/src/concrete/RainlangInterpreter.ierc165.t.sol
  • test/src/concrete/RainlangInterpreter.t.sol
  • test/src/concrete/RainlangInterpreter.zeroFunctionPointers.t.sol
  • test/src/concrete/RainlangParser.ierc165.t.sol
  • test/src/concrete/RainlangParser.parseMemoryOverflow.t.sol
  • test/src/concrete/RainlangParser.parsePragmaEmpty.t.sol
  • test/src/concrete/RainlangParser.parserPragma.t.sol
  • test/src/concrete/RainlangReferenceExtern.bytecode.t.sol
  • test/src/concrete/RainlangReferenceExtern.describedByMetaV1.t.sol
  • test/src/concrete/RainlangReferenceExtern.ierc165.t.sol
  • test/src/concrete/RainlangReferenceExtern.pointers.t.sol
  • test/src/concrete/RainlangReferenceExtern.subParserIndexOutOfBounds.t.sol
  • test/src/concrete/RainlangStore.getUninitialized.t.sol
  • test/src/concrete/RainlangStore.ierc165.t.sol
  • test/src/concrete/RainlangStore.namespaceIsolation.t.sol
  • test/src/concrete/RainlangStore.overwriteKey.t.sol
  • test/src/concrete/RainlangStore.setEmpty.t.sol
  • test/src/concrete/RainlangStore.setEvent.t.sol
  • test/src/concrete/RainlangStore.t.sol
  • test/src/lib/eval/LibEval.fBounds.t.sol
  • test/src/lib/eval/LibEval.inputsLengthMismatch.t.sol
  • test/src/lib/extern/LibExtern.codec.t.sol
  • test/src/lib/extern/reference/literal/LibParseLiteralRepeat.t.sol
  • test/src/lib/extern/reference/op/LibExternOpContextCallingContract.subParser.t.sol
  • test/src/lib/extern/reference/op/LibExternOpContextRainlen.subParser.t.sol
  • test/src/lib/extern/reference/op/LibExternOpContextSender.subParser.t.sol
  • test/src/lib/extern/reference/op/LibExternOpStackOperand.subParser.t.sol
  • test/src/lib/integrity/LibIntegrityCheck.newState.t.sol
  • test/src/lib/integrity/LibIntegrityCheck.t.sol
  • test/src/lib/op/00/LibOpContext.t.sol
  • test/src/lib/op/LibAllStandardOps.filesystemOrdering.t.sol
  • test/src/lib/op/LibAllStandardOps.t.sol
  • test/src/lib/op/math/LibOpMul.t.sol
  • test/src/lib/op/math/uint256/LibOpUint256Power.t.sol
  • test/src/lib/parse/LibParse.empty.gas.t.sol
  • test/src/lib/parse/LibParse.ignoredLHS.t.sol
  • test/src/lib/parse/LibParse.inputsOnly.gas.t.sol
  • test/src/lib/parse/LibParse.inputsOnly.t.sol
  • test/src/lib/parse/LibParse.lhsOverflow.t.sol
  • test/src/lib/parse/LibParse.literalIntegerHex.t.sol
  • test/src/lib/parse/LibParse.literalString.t.sol
  • test/src/lib/parse/LibParse.parseMemoryOverflow.t.sol
  • test/src/lib/parse/LibParse.parseWord.t.sol
  • test/src/lib/parse/LibParse.singleIgnored.gas.t.sol
  • test/src/lib/parse/LibParse.singleLHSNamed.gas.t.sol
  • test/src/lib/parse/LibParse.singleRHSNamed.gas.t.sol
  • test/src/lib/parse/LibParse.sourceInputs.t.sol
  • test/src/lib/parse/LibParse.unexpectedRightParen.t.sol
  • test/src/lib/parse/LibParse.wordsRHS.t.sol
  • test/src/lib/parse/LibParseError.t.sol
  • test/src/lib/parse/LibParseInterstitial.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperand.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperand8M1M1.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandDisallowed.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandDisallowedAlwaysOne.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandDoublePerByteNoDefault.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandM1M1.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandSingleFull.t.sol
  • test/src/lib/parse/LibParseOperand.handleOperandSingleFullNoDefault.t.sol
  • test/src/lib/parse/LibParseOperand.parseOperand.t.sol
  • test/src/lib/parse/LibParsePragma.keyword.t.sol
  • test/src/lib/parse/LibParseStackName.t.sol
  • test/src/lib/parse/LibParseStackTracker.t.sol
  • test/src/lib/parse/LibParseState.buildBytecode.t.sol
  • test/src/lib/parse/LibParseState.buildConstants.t.sol
  • test/src/lib/parse/LibParseState.checkParseMemoryOverflow.t.sol
  • test/src/lib/parse/LibParseState.constantValueBloom.t.sol
  • test/src/lib/parse/LibParseState.danglingSource.t.sol
  • test/src/lib/parse/LibParseState.endLine.unboundedLHS.t.sol
  • test/src/lib/parse/LibParseState.endSource.t.sol
  • test/src/lib/parse/LibParseState.exportSubParsers.t.sol
  • test/src/lib/parse/LibParseState.highwaterOverflow.t.sol
  • test/src/lib/parse/LibParseState.newActiveSourcePointer.t.sol
  • test/src/lib/parse/LibParseState.offsets.t.sol
  • test/src/lib/parse/LibParseState.parenInputOverflow.t.sol
  • test/src/lib/parse/LibParseState.pushConstantValue.t.sol
  • test/src/lib/parse/LibParseState.pushLiteral.t.sol
  • test/src/lib/parse/LibParseState.pushOpToSource.LHSCorruption.t.sol
  • test/src/lib/parse/LibParseState.pushOpToSource.t.sol
  • test/src/lib/parse/LibParseState.pushOpToSourceLHSCorruption.t.sol
  • test/src/lib/parse/LibParseState.pushSubParser.largeMemory.t.sol
  • test/src/lib/parse/LibParseState.pushSubParser.t.sol
  • test/src/lib/parse/LibSubParse.constantAccumulation.t.sol
  • test/src/lib/parse/LibSubParse.consumeSubParseLiteralInputData.t.sol
  • test/src/lib/parse/LibSubParse.consumeSubParseWordInputData.t.sol
  • test/src/lib/parse/LibSubParse.subParseLiteral.t.sol
  • test/src/lib/parse/LibSubParse.subParseWords.t.sol
  • test/src/lib/parse/LibSubParse.subParserConstant.t.sol
  • test/src/lib/parse/LibSubParse.subParserContext.t.sol
  • test/src/lib/parse/LibSubParse.subParserExtern.t.sol
  • test/src/lib/parse/LibSubParse.unknownWord.t.sol
  • test/src/lib/parse/literal/LibParseLiteral.dispatch.t.sol
  • test/src/lib/parse/literal/LibParseLiteral.selectByIndex.t.sol
  • test/src/lib/parse/literal/LibParseLiteralDecimal.parseDecimalFloat.t.sol
  • test/src/lib/parse/literal/LibParseLiteralHex.parseHex.t.sol
  • test/src/lib/parse/literal/LibParseLiteralString.boundString.t.sol
  • test/src/lib/parse/literal/LibParseLiteralString.parseString.t.sol
  • test/src/lib/parse/literal/LibParseLiteralSubParseable.parseSubParseable.t.sol
  • test/src/lib/state/LibInterpreterState.fingerprint.t.sol
  • test/src/lib/state/LibInterpreterState.stackBottoms.t.sol
  • test/src/lib/state/LibInterpreterState.stackTrace.t.sol
  • test/src/lib/state/LibInterpreterStateDataContract.t.sol

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 2a2a1f4 into main Sep 7, 2026
5 checks passed
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant