Skip to content

Pin rain-math-float 0.2.1 and rain-math-float-deploy 0.1.2 - #580

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-09-09-rain-math-float-0.2.1
Sep 9, 2026
Merged

thedavidmeister merged 1 commit into
mainfrom
2026-09-09-rain-math-float-0.2.1

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Pins rain-math-float 0.2.1 in place of 0.1.1 and adds rain-math-float-deploy 0.1.2.

The library half of the split no longer ships LibDecimalFloatDeploy, so the six transcendental words that pass the on-chain log-tables address (pow, sqrt, gm, exp2, exp, exponential growth) now import it from the deploy package. rain.math.float.deploy 0.1.2 exists so that package spells rain-math-float-0.2.1/ in its own imports, which with recursive_deps off and no aliasing is the only way both can be pinned together. Its deployed tables are the same bytes at the same address.

0.2.1 brings LibDecimalFloat.FLOAT_PI; #579 (the pi word) switches to it on top of this.

QA

  • Discriminating tests: full suite over the new pins, 1485 passed locally; the 6 failures are the fork-based math op suites whose constructor needs ARBITRUM_RPC_URL, which CI has. No word's bytecode changes (the library diff between the pins is one unused constant), so the generated pointers are byte-identical, which git-clean currency checks.
  • Mutations applied: n/a, a pin bump with no logic change; every diff line is the two pins, the lockfile, or an import prefix rewrite (verified by normalising both prefixes and diffing).
  • Oracle: the suite, unchanged; soldeer.lock checksums for both packages from the registry.
  • Category check: dependency bump only; the six deploy-lib imports are the only import path change beyond the version prefix.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq

Summary by CodeRabbit

  • Maintenance

    • Updated the underlying decimal floating-point mathematics components to newer versions.
    • Added the corresponding deployment support package.
    • Existing application behavior and configuration remain unchanged.
  • Compatibility

    • Updated related integrations and validation coverage to use the newer mathematics components consistently.
    • No new user-facing features, workflow changes, or publicly visible API changes are included.

The library no longer ships LibDecimalFloatDeploy; the log-tables address
the transcendental words pass comes from the deploy package, which spells
the same library version.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b4ab5ee7-6058-4fdd-a1d2-9a0f3137d2eb

📥 Commits

Reviewing files that changed from the base of the PR and between 16c2d92 and 7308017.

⛔ Files ignored due to path filters (1)
  • soldeer.lock is excluded by !**/*.lock
📒 Files selected for processing (98)
  • foundry.toml
  • remappings.txt
  • src/concrete/extern/RainlangReferenceExtern.sol
  • src/lib/extern/reference/op/LibExternOpIntInc.sol
  • src/lib/op/erc20/LibOpERC20Allowance.sol
  • src/lib/op/erc20/LibOpERC20BalanceOf.sol
  • src/lib/op/erc20/LibOpERC20TotalSupply.sol
  • src/lib/op/erc721/LibOpERC721BalanceOf.sol
  • src/lib/op/evm/LibOpBlockNumber.sol
  • src/lib/op/evm/LibOpBlockTimestamp.sol
  • src/lib/op/evm/LibOpChainId.sol
  • src/lib/op/logic/LibOpAny.sol
  • src/lib/op/logic/LibOpConditions.sol
  • src/lib/op/logic/LibOpEnsure.sol
  • src/lib/op/logic/LibOpEqualTo.sol
  • src/lib/op/logic/LibOpEvery.sol
  • src/lib/op/logic/LibOpGreaterThan.sol
  • src/lib/op/logic/LibOpGreaterThanOrEqualTo.sol
  • src/lib/op/logic/LibOpIf.sol
  • src/lib/op/logic/LibOpIsZero.sol
  • src/lib/op/logic/LibOpLessThan.sol
  • src/lib/op/logic/LibOpLessThanOrEqualTo.sol
  • src/lib/op/math/LibOpAbs.sol
  • src/lib/op/math/LibOpAdd.sol
  • src/lib/op/math/LibOpAvg.sol
  • src/lib/op/math/LibOpCeil.sol
  • src/lib/op/math/LibOpDiv.sol
  • src/lib/op/math/LibOpE.sol
  • src/lib/op/math/LibOpExp.sol
  • src/lib/op/math/LibOpExp2.sol
  • src/lib/op/math/LibOpFloor.sol
  • src/lib/op/math/LibOpFrac.sol
  • src/lib/op/math/LibOpGm.sol
  • src/lib/op/math/LibOpHeadroom.sol
  • src/lib/op/math/LibOpInv.sol
  • src/lib/op/math/LibOpMax.sol
  • src/lib/op/math/LibOpMaxNegativeValue.sol
  • src/lib/op/math/LibOpMaxPositiveValue.sol
  • src/lib/op/math/LibOpMin.sol
  • src/lib/op/math/LibOpMinNegativeValue.sol
  • src/lib/op/math/LibOpMinPositiveValue.sol
  • src/lib/op/math/LibOpMul.sol
  • src/lib/op/math/LibOpPower.sol
  • src/lib/op/math/LibOpSqrt.sol
  • src/lib/op/math/LibOpSub.sol
  • src/lib/op/math/growth/LibOpExponentialGrowth.sol
  • src/lib/op/math/growth/LibOpLinearGrowth.sol
  • src/lib/parse/LibParseOperand.sol
  • src/lib/parse/literal/LibParseLiteralDecimal.sol
  • test/abstract/OpTest.sol
  • test/src/concrete/RainlangInterpreter.eval.nonZeroSourceIndex.t.sol
  • test/src/concrete/RainlangInterpreter.eval.t.sol
  • test/src/concrete/RainlangInterpreter.stateOverlay.t.sol
  • test/src/concrete/RainlangReferenceExtern.intInc.t.sol
  • test/src/lib/op/00/LibOpConstant.t.sol
  • test/src/lib/op/00/LibOpExtern.t.sol
  • test/src/lib/op/00/LibOpStack.t.sol
  • test/src/lib/op/call/LibOpCall.t.sol
  • test/src/lib/op/crypto/LibOpHash.t.sol
  • test/src/lib/op/erc20/LibOpERC20Allowance.t.sol
  • test/src/lib/op/erc20/LibOpERC20BalanceOf.t.sol
  • test/src/lib/op/erc20/LibOpERC20TotalSupply.t.sol
  • test/src/lib/op/erc721/LibOpERC721BalanceOf.t.sol
  • test/src/lib/op/logic/LibOpConditions.t.sol
  • test/src/lib/op/logic/LibOpEnsure.t.sol
  • test/src/lib/op/logic/LibOpEvery.t.sol
  • test/src/lib/op/logic/LibOpIf.t.sol
  • test/src/lib/op/math/LibOpAbs.t.sol
  • test/src/lib/op/math/LibOpAdd.t.sol
  • test/src/lib/op/math/LibOpAvg.t.sol
  • test/src/lib/op/math/LibOpCeil.t.sol
  • test/src/lib/op/math/LibOpDiv.t.sol
  • test/src/lib/op/math/LibOpE.t.sol
  • test/src/lib/op/math/LibOpExp.t.sol
  • test/src/lib/op/math/LibOpExp2.t.sol
  • test/src/lib/op/math/LibOpFloor.t.sol
  • test/src/lib/op/math/LibOpFrac.t.sol
  • test/src/lib/op/math/LibOpGm.t.sol
  • test/src/lib/op/math/LibOpHeadroom.t.sol
  • test/src/lib/op/math/LibOpInv.t.sol
  • test/src/lib/op/math/LibOpMax.t.sol
  • test/src/lib/op/math/LibOpMaxNegativeValue.t.sol
  • test/src/lib/op/math/LibOpMaxPositiveValue.t.sol
  • test/src/lib/op/math/LibOpMin.t.sol
  • test/src/lib/op/math/LibOpMinNegativeValue.t.sol
  • test/src/lib/op/math/LibOpMinPositiveValue.t.sol
  • test/src/lib/op/math/LibOpMul.t.sol
  • test/src/lib/op/math/LibOpPower.t.sol
  • test/src/lib/op/math/LibOpSqrt.t.sol
  • test/src/lib/op/math/LibOpSub.t.sol
  • test/src/lib/op/math/growth/LibOpExponentialGrowth.t.sol
  • test/src/lib/op/math/growth/LibOpLinearGrowth.t.sol
  • test/src/lib/parse/LibParse.literalIntegerDecimal.t.sol
  • test/src/lib/parse/LibParse.namedLHS.t.sol
  • test/src/lib/parse/LibParseOperand.parseOperand.t.sol
  • test/src/lib/parse/literal/LibParseLiteral.dispatch.t.sol
  • test/src/lib/parse/literal/LibParseLiteral.selectByIndex.t.sol
  • test/src/lib/parse/literal/LibParseLiteralDecimal.parseDecimalFloat.t.sol

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The project adds rain-math-float-deploy 0.1.2, upgrades rain-math-float to 0.2.1, and updates production and test imports. No runtime logic or test behavior changes.

Changes

Rain math dependency upgrade

Layer / File(s) Summary
Dependency configuration
foundry.toml, remappings.txt
Adds rain-math-float-deploy 0.1.2 and updates rain-math-float to 0.2.1.
Production import migration
src/concrete/..., src/lib/...
Updates source imports to rain-math-float 0.2.1 and deployment-library imports to rain-math-float-deploy 0.1.2.
Test import migration
test/abstract/..., test/src/...
Updates test imports and related error definitions to rain-math-float 0.2.1 without changing test logic.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 73080

This updates decimal-float dependency imports and deploy-library mappings without changing opcode logic. The dependency configuration and migrated imports are aligned, so no current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main changes: pinning rain-math-float to 0.2.1 and adding rain-math-float-deploy at 0.1.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-09-09-rain-math-float-0.2.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 7488666 into main Sep 9, 2026
5 checks passed
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant