Pin rain-math-float 0.2.1 and rain-math-float-deploy 0.1.2 - #580
Conversation
The library no longer ships LibDecimalFloatDeploy; the log-tables address the transcendental words pass comes from the deploy package, which spells the same library version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (98)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe project adds ChangesRain math dependency upgrade
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This updates decimal-float dependency imports and deploy-library mappings without changing opcode logic. The dependency configuration and migrated imports are aligned, so no current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Pins
rain-math-float0.2.1 in place of 0.1.1 and addsrain-math-float-deploy0.1.2.The library half of the split no longer ships
LibDecimalFloatDeploy, so the six transcendental words that pass the on-chain log-tables address (pow,sqrt,gm,exp2,exp, exponential growth) now import it from the deploy package. rain.math.float.deploy 0.1.2 exists so that package spellsrain-math-float-0.2.1/in its own imports, which withrecursive_depsoff and no aliasing is the only way both can be pinned together. Its deployed tables are the same bytes at the same address.0.2.1 brings
LibDecimalFloat.FLOAT_PI; #579 (thepiword) switches to it on top of this.QA
ARBITRUM_RPC_URL, which CI has. No word's bytecode changes (the library diff between the pins is one unused constant), so the generated pointers are byte-identical, which git-clean currency checks.soldeer.lockchecksums for both packages from the registry.🤖 Generated with Claude Code
https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
Summary by CodeRabbit
Maintenance
Compatibility