Change comments in ExportWaveAsCode to be C89 compliant - #28
Open
michaeljosephpurdy wants to merge 1 commit into
Open
michaeljosephpurdy wants to merge 1 commit into
michaeljosephpurdy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I've got a codebase I'm working on that I compile with C89 flags.
I came across
rfxgen(super cool project!) and I'm using that to define and build sounds and package them directly into my codebase.The comments are all C99 styled
//.While this is probably only a me problem, I thought that maybe some others may be a similar situation and getting warnings (or, like I am, warnings upgraded to errors 😊 )when using the exported files.
I didn't see a
CONTRIBUTE.mdor anything so not sure if I should create an Issue for this, or if contributions are even open, but figured I'd throw a PR out and see if it sticks.Thanks for the great tools 🤙