Improve a11y by using button with role switch#26
Merged
Conversation
As for [mozilla switch guidelines](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_switch_role) Plus I switched `span` for `button` to get support for `Enter` and `Space` keys out of the box (now the browser will take care about it and that's why I deleted the test, cause enzyme doesn't fire `onClick` on such keypresses, but the browsers will do)
AoDev
reviewed
Sep 10, 2018
Contributor
Author
|
@zombieJ , are you busy or you're waiting for me to fix the coverage? Cause right now I don't why the coverage is decreased. I've deleted a test, but also deleted the code the test was testing. coveralls report doesn't help either |
Member
|
I'm OK with this. |
afc163
reviewed
Sep 11, 2018
| expect(switcher.state().checked).toBe(true); | ||
| switcher.simulate('keydown', { keyCode: 13 }); | ||
| expect(switcher.state().checked).toBe(false); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
enzyme doesn't fire onClick on such keypresses, but the browsers will call onClick because it's button
Plus, if we'll try to test such behavior we will be actually testing a11y specification, which i think we shouldn't do
Member
|
cool |
Member
Contributor
Author
|
@afc163 answered in the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for mozilla switch guidelines
Plus I switched
spanforbuttonto get support forEnterandSpacekeys out of the box (now the browser will take care about it and that's why I deleted the test, cause enzyme doesn't fireonClickon such keypresses, but the browsers will do)Fixes #22