Skip to content

feat: add headerAlign and bodyAlign#155

Closed
marswong wants to merge 1 commit into
react-component:masterfrom
marswong:master
Closed

feat: add headerAlign and bodyAlign#155
marswong wants to merge 1 commit into
react-component:masterfrom
marswong:master

Conversation

@marswong

@marswong marswong commented Aug 13, 2017

Copy link
Copy Markdown

@benjycui refer to ant-design/ant-design#2465, and #137 can be closed.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.326% when pulling 9a3416d on marswong:master into 7b5e1a6 on react-component:master.

@marswong marswong changed the title feat: add headerAlign and bodyAlign(ant-design/ant-design#2465) feat: add headerAlign and bodyAlign Aug 13, 2017
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.326% when pulling 9589a5e on marswong:master into 7b5e1a6 on react-component:master.

@afc163

afc163 commented Aug 14, 2017

Copy link
Copy Markdown
Member
columns={[{
  'align': 'left',
}]}

This will be better.

@marswong

marswong commented Aug 14, 2017

Copy link
Copy Markdown
Author

I thought about this, seperated config is flexible, but uncommon in daily usage.
Such as the statistic data always need a table with unified center-aligned table head and right-aligned table body.
So it may be better to expose a unified config API, and if really needed, users can just set text-align in the column render function, but it's really uncommon

@afc163

afc163 commented Aug 31, 2017

Copy link
Copy Markdown
Member

It is a common usage for sepecify align for one column: https://ant.design/components/table/#components-table-demo-bordered So #137 maybe a better solution for it.

@marswong

marswong commented Sep 1, 2017

Copy link
Copy Markdown
Author

Got it.

@marswong marswong closed this Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants