fix: open Metro in the correct terminal#310

Merged

grabbou merged 23 commits into

react-native-community:masterfrom

lucasbento:feature/correct-terminal

Apr 17, 2019

Commits on Apr 11, 2019

Put `isPackagerRunning` function on `cli-tools` to share between iOS & Android
Lucas Bento
committed
Fix `terminal` argument not working when not being provided
Lucas Bento
committed
Fallback to the default terminal of the machine when starting the packager on `run-android`
Lucas Bento
committed
Delete `isPackagerRunning` as it was moved to `tools`
Lucas Bento
committed
Add `terminal` argument to `run-ios`
Lucas Bento
committed
Launch Metro from within the `runIOS` command
Lucas Bento
committed

Commits on Apr 12, 2019

Remove code & add `—terminal` argument
Lucas Bento
committed
Try using `REACT_TERMINAL` before the default terminal
Lucas Bento
committed

Commits on Apr 13, 2019

Put `isPackagerRunning` function on `cli-tools` to share between iOS & Android

Lucas Bento
authored and
thymikee
committed
Fix `terminal` argument not working when not being provided

Lucas Bento
authored and
thymikee
committed
Fallback to the default terminal of the machine when starting the packager on `run-android`

Lucas Bento
authored and
thymikee
committed
Delete `isPackagerRunning` as it was moved to `tools`

Lucas Bento
authored and
thymikee
committed
Add `terminal` argument to `run-ios`

Lucas Bento
authored and
thymikee
committed
Launch Metro from within the `runIOS` command

Lucas Bento
authored and
thymikee
committed
Remove code & add `—terminal` argument

Lucas Bento
authored and
thymikee
committed
Try using `REACT_TERMINAL` before the default terminal

Lucas Bento
authored and
thymikee
committed

Commits on Apr 17, 2019

Add tool function to get the default user terminal
Lucas Bento
committed
Fix `terminal` arg type
Lucas Bento
committed
Remove spread and specify entry twice instead
Lucas Bento
committed
Merge branch 'feature/correct-terminal' of https://github.com/lucasbento/cli into feature/correct-terminal
Lucas Bento
committed
Improve `args` being passed through functions
Lucas Bento
committed
Reduce code duplication
Lucas Bento
committed
Put `device` and `udid` variable up in the scope
Lucas Bento
committed