bump Folly to 2024.10.14.00#47033
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
8afe300 to
e2bb08c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
e2bb08c to
83963e5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
83963e5 to
de7d2b6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
de7d2b6 to
bfdd6c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
bfdd6c1 to
bfd1b03
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
bfd1b03 to
af4a06c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
9d9dab4 to
ed36ab5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
ed36ab5 to
da36a80
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
da36a80 to
69c5e9e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
69c5e9e to
fed95ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
fed95ac to
9d9bd8e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
9d9bd8e to
a7fe5c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
8855629 to
12718f5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
12718f5 to
42cad19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
42cad19 to
ce9e89a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
Summary: Pull Request resolved: #47033 Lastest Folly has updates to fix build errors with LLVM 19 which is also llikely needed for NDK 27 - facebook/folly@bf46c8a - also add folly's new dependency fast_float - update fmt version Changelog: [General][Changed] - Bump Folly to 2024.10.14.00 Reviewed By: cortinico Differential Revision: D64372125
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64372125 |
ce9e89a to
ec8c5ef
Compare
Collaborator
|
This pull request was successfully merged by @alanleedev in 37375d8 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 37375d8. |
5 tasks
meta-codesync Bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Summary: Follow-up to - #47033 - #50431 TODO - [x] bump packages/react-native/third-party-podspecs/fmt.podspec - [x] bump scripts/releases/ios-prebuild/configuration.js - [x] packages/react-native/third-party-podspecs/RCT-Folly.podspec - [x] packages/react-native/gradle/libs.versions.toml - [x] packages/rn-tester/Podfile.lock - rn-rester (main) ios not building on Xcode 26.3, CI currently only supports Xcode 16 - i cannot downgrade macos26.4b4 locally to macos15 to install Xcode16.4 and bump pods this way - so on Xcode 26.3 i've attempted to bump only fmt minimally, ignoring remaining RN 0.86 hashes Ref: https://github.com/search?q=repo%3Afacebook%2Freact-native+%2211.0.2%22&type=code however unable to test rn-tester, ios doesn't seem to build on Xcode 26.3 let alone 26.4b not tested previous versions of Xcode not tested prior branches/tags to main rn-tester CI is passing on old macos-15 Xcode 16.4.0 only, ideally this should be extended to stable macos lts and Xcode 26.3 stable first separate follow-ups to this minimal fmt bump - bump CI macos-15 xcode 16.1-4 to macos-26 xcode 26.0-3 - bump rn-tester Podfile.lock from RN 0.82 to 0.86 main (aka nightly) - bump folly to 2025.11.03.00 - bump folly to 2026.03.09.00 Resolve: #55601 ## Changelog: [General][Changed] Bump fmt to 12.1.0 to fix Xcode 26.4 Pull Request resolved: #56099 Test Plan: RNTester Reviewed By: alanleedev Differential Revision: D97358194 Pulled By: cipolleschi fbshipit-source-id: 3eb578a99a310e3eb77433692bf35502d0d78d24
alanleedev
pushed a commit
that referenced
this pull request
Mar 20, 2026
Summary: Follow-up to - #47033 - #50431 TODO - [x] bump packages/react-native/third-party-podspecs/fmt.podspec - [x] bump scripts/releases/ios-prebuild/configuration.js - [x] packages/react-native/third-party-podspecs/RCT-Folly.podspec - [x] packages/react-native/gradle/libs.versions.toml - [x] packages/rn-tester/Podfile.lock - rn-rester (main) ios not building on Xcode 26.3, CI currently only supports Xcode 16 - i cannot downgrade macos26.4b4 locally to macos15 to install Xcode16.4 and bump pods this way - so on Xcode 26.3 i've attempted to bump only fmt minimally, ignoring remaining RN 0.86 hashes Ref: https://github.com/search?q=repo%3Afacebook%2Freact-native+%2211.0.2%22&type=code however unable to test rn-tester, ios doesn't seem to build on Xcode 26.3 let alone 26.4b not tested previous versions of Xcode not tested prior branches/tags to main rn-tester CI is passing on old macos-15 Xcode 16.4.0 only, ideally this should be extended to stable macos lts and Xcode 26.3 stable first separate follow-ups to this minimal fmt bump - bump CI macos-15 xcode 16.1-4 to macos-26 xcode 26.0-3 - bump rn-tester Podfile.lock from RN 0.82 to 0.86 main (aka nightly) - bump folly to 2025.11.03.00 - bump folly to 2026.03.09.00 Resolve: #55601 [General][Changed] Bump fmt to 12.1.0 to fix Xcode 26.4 Pull Request resolved: #56099 Test Plan: RNTester Reviewed By: alanleedev Differential Revision: D97358194 Pulled By: cipolleschi fbshipit-source-id: 3eb578a99a310e3eb77433692bf35502d0d78d24
gabrieldonadel
pushed a commit
that referenced
this pull request
Apr 10, 2026
Summary: Follow-up to - #47033 - #50431 TODO - [x] bump packages/react-native/third-party-podspecs/fmt.podspec - [x] bump scripts/releases/ios-prebuild/configuration.js - [x] packages/react-native/third-party-podspecs/RCT-Folly.podspec - [x] packages/react-native/gradle/libs.versions.toml - [x] packages/rn-tester/Podfile.lock - rn-rester (main) ios not building on Xcode 26.3, CI currently only supports Xcode 16 - i cannot downgrade macos26.4b4 locally to macos15 to install Xcode16.4 and bump pods this way - so on Xcode 26.3 i've attempted to bump only fmt minimally, ignoring remaining RN 0.86 hashes Ref: https://github.com/search?q=repo%3Afacebook%2Freact-native+%2211.0.2%22&type=code however unable to test rn-tester, ios doesn't seem to build on Xcode 26.3 let alone 26.4b not tested previous versions of Xcode not tested prior branches/tags to main rn-tester CI is passing on old macos-15 Xcode 16.4.0 only, ideally this should be extended to stable macos lts and Xcode 26.3 stable first separate follow-ups to this minimal fmt bump - bump CI macos-15 xcode 16.1-4 to macos-26 xcode 26.0-3 - bump rn-tester Podfile.lock from RN 0.82 to 0.86 main (aka nightly) - bump folly to 2025.11.03.00 - bump folly to 2026.03.09.00 Resolve: #55601 [General][Changed] Bump fmt to 12.1.0 to fix Xcode 26.4 Pull Request resolved: #56099 Test Plan: RNTester Reviewed By: alanleedev Differential Revision: D97358194 Pulled By: cipolleschi fbshipit-source-id: 3eb578a99a310e3eb77433692bf35502d0d78d24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Lastest Folly has updates to fix build errors with LLVM 19 which is also llikely needed for NDK 27
Changelog:
[General][Changed] - Bump Folly to 2024.10.14.00
Differential Revision: D64372125