feat: js runtime switching C API for Swift#49489
Closed
okwasniewski wants to merge 1 commit into
Closed
Conversation
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
from
February 18, 2025 08:50
2462cd0 to
1ac60cc
Compare
robik
reviewed
Feb 18, 2025
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
3 times, most recently
from
February 18, 2025 15:09
a322ee1 to
26adda3
Compare
okwasniewski
marked this pull request as ready for review
February 18, 2025 15:10
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
from
February 18, 2025 15:10
26adda3 to
71e5ca1
Compare
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
3 times, most recently
from
February 18, 2025 15:28
6eeac5e to
2101bc7
Compare
Kudo
reviewed
Feb 19, 2025
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
6 times, most recently
from
February 20, 2025 15:02
eef1a8f to
b7cd241
Compare
Kudo
reviewed
Feb 20, 2025
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
2 times, most recently
from
February 21, 2025 08:42
939c55d to
af32fe8
Compare
cipolleschi
approved these changes
Feb 21, 2025
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I just left a question
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
also looks good to me. thanks for following up my questions |
okwasniewski
force-pushed
the
feat/jsruntime-c-api
branch
from
February 24, 2025 12:37
af32fe8 to
a6e9926
Compare
Contributor
|
@cipolleschi merged this pull request in a6607c0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Note
This PR is part of JavaScriptCore Extraction to this repository: https://github.com/react-native-community/javascriptcore
This PR implements a C API to switch JS Engines that can be used from Swift.
Here is an example:
Changelog:
[IOS] [ADDED] - js runtime C API for Swift
Test Plan:
CI Green