[iOS] Fabric: Only add selection of textinput payload when event is selectionChange#51051
Closed
zhongwuzw wants to merge 4 commits into
Closed
[iOS] Fabric: Only add selection of textinput payload when event is selectionChange#51051zhongwuzw wants to merge 4 commits into
zhongwuzw wants to merge 4 commits into
Conversation
Contributor
|
cc @cipolleschi is this something you can import/review/merge? |
cipolleschi
approved these changes
Jun 9, 2025
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Code looks good to me.
I wonder how the types on JS get messed up like this.
To be fair, the selectionChange event doesn't have the text property either... and I don't know why the selectionChange event does not have the eventCount: number; that the textChanged has...
I'll import this and ask these questions to other people internally.
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
requested changes
Jun 9, 2025
|
|
||
| static jsi::Value textInputMetricsPayload( | ||
| jsi::Runtime& runtime, | ||
| const std::string& name, |
Contributor
There was a problem hiding this comment.
some internal feedback: can we instead have something like includeSelectionState as a boolean to avoid the string comparison?
…/consolidate_textinput_change
cipolleschi
approved these changes
Jun 16, 2025
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 3bfbaa8 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@cipolleschi merged this pull request in 3bfbaa8. |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Jan 6, 2026
Summary: This change adds `selection` data to the `TextInput.onChange` event for both iOS and Android platforms. NOTE: `selection` only represents the cursor location when returned via `onChange` as this will not be invoked on a pure selection change without text change. We should also add this note to the documentation. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. React Native's `onChange` event previously included `selection` on iOS (Fabric), but this was removed in PR [react#51051](react#51051) to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards. This is also to support pollyfill added in `react-strict-dom`; react/react-strict-dom#435 ## What Changed 1. **iOS/macOS (C++)**: Enable selection in `onChange` event via `TextInputEventEmitter` 2. **Android (Kotlin)**: Added selection data to `ReactTextChangedEvent` Changelog: [General][Added] - TextInput onChange event now includes selection data (cursor location) on iOS and Android Reviewed By: cipolleschi, javache Differential Revision: D90123295
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
Summary: Pull Request resolved: #55044 This change adds `selection` data to the `TextInput.onChange` event for both iOS and Android platforms. NOTE: `selection` only represents the cursor location when returned via `onChange` as this will not be invoked on a pure selection change without text change. We should also add this note to the documentation. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. React Native's `onChange` event previously included `selection` on iOS (Fabric), but this was removed in PR [#51051](#51051) to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards. This is also to support pollyfill added in `react-strict-dom`; react/react-strict-dom#435 ## What Changed 1. **iOS/macOS (C++)**: Enable selection in `onChange` event via `TextInputEventEmitter` 2. **Android (Kotlin)**: Added selection data to `ReactTextChangedEvent` Changelog: [General][Added] - TextInput onChange event now includes selection data (cursor location) on iOS and Android Reviewed By: cipolleschi, javache Differential Revision: D90123295 fbshipit-source-id: 988ce4ce737e8b297313ade8bfaa2cbbfc9758cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #51020: TextInputChangeEventData does not contain selection (see here). Additionally, Android does not have selection either (see here) (iOS old arch also not contains it). We can consolidate these to prevent any misleading information.
Changelog:
[IOS] [FIXED] - Fabric: Only add selection of textinput payload when event is selectionChange
Test Plan:
TextInput
onChange's event should not containsselection.