Add selection types to TextInput onChange event#55043
Closed
alanleedev wants to merge 1 commit into
Closed
Conversation
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90123294. |
3b08fdb to
9b6cbb7
Compare
9b6cbb7 to
7d28459
Compare
7d28459 to
a157205
Compare
Summary: This change adds TypeScript/Flow types and RNTester examples for the `selection` data in `TextInput.onChange` event. This is the JS companion to the native changes that add selection data to the onChange event. NOTE:selection only represents the cursor location when returned via onChange as this will not be invoked on a pure selection change without text change. We should also add this note to the documentation. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. This change exposes the selection data that native now provides, allowing developers to access cursor position during onChange. ## What Changed 1. **Flow Types**: Added optional `selection?: Selection` to `TextInputChangeEventData` 2. **TypeScript Types**: Updated `ReactNativeApi.d.ts` with selection type 3. **RNTester**: Updated examples to display selection in event logs Changelog: [General][Added] - TextInput onChange event types now include optional selection data Reviewed By: cipolleschi, necolas Differential Revision: D90123294
a157205 to
1f4e931
Compare
Collaborator
|
This pull request was successfully merged by @alanleedev in c1f5445 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in c1f5445. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds TypeScript/Flow types and RNTester examples for the
selectiondata inTextInput.onChangeevent.This is the JS companion to the native changes that add selection data to the onChange event.
Why
On the web, text input elements provide
selectionStartandselectionEndproperties that are always accessible during input events. This change exposes the selection data that native now provides, allowing developers to access cursor position during onChange.What Changed
selection?: SelectiontoTextInputChangeEventDataReactNativeApi.d.tswith selection typeChangelog
[General][Added] - TextInput onChange event types now include optional selection data
Differential Revision: D90123294