Skip to content

[NativeAnimated] Add support for DiffClamp node#9691

Closed
janicduplessis wants to merge 1 commit into
react:masterfrom
janicduplessis:native-diff-clamp
Closed

[NativeAnimated] Add support for DiffClamp node#9691
janicduplessis wants to merge 1 commit into
react:masterfrom
janicduplessis:native-diff-clamp

Conversation

@janicduplessis

@janicduplessis janicduplessis commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Add native support on iOS and Android for Animated.diffClamp that was added in #9419.

Test plan
Tested that it works properly using the native animations UIExplorer example.

@janicduplessis

janicduplessis commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author

cc @brentvatne

@ghost

ghost commented Aug 31, 2016

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @buba447 and @ryangomba to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 31, 2016
@ghost

ghost commented Aug 31, 2016

Copy link
Copy Markdown

@janicduplessis updated the pull request - view changes

@ghost

ghost commented Aug 31, 2016

Copy link
Copy Markdown

@janicduplessis updated the pull request - view changes

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2016
@brentvatne

brentvatne commented Sep 2, 2016

Copy link
Copy Markdown
Collaborator

lgtm!

@brentvatne

brentvatne commented Sep 2, 2016

Copy link
Copy Markdown
Collaborator

@facebook-github-bot shipit

@ghost ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 2, 2016
@ghost

ghost commented Sep 2, 2016

Copy link
Copy Markdown

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 2, 2016
@ghost

ghost commented Sep 3, 2016

Copy link
Copy Markdown

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2016
@janicduplessis

janicduplessis commented Sep 5, 2016

Copy link
Copy Markdown
Contributor Author

@brentvatne rebased to fix conflict

@ghost

ghost commented Sep 5, 2016

Copy link
Copy Markdown

@janicduplessis updated the pull request - view changes - changes since last import

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2016
@brentvatne

brentvatne commented Sep 6, 2016

Copy link
Copy Markdown
Collaborator

@facebook-github-bot shipit

@ghost ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 6, 2016
@facebook-github-bot

facebook-github-bot commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2016
@ghost ghost closed this in e26c135 Sep 6, 2016
ide pushed a commit to expo/react-native that referenced this pull request Sep 7, 2016
@janicduplessis @ide
Add support for DiffClamp node
05824db 
Summary:
Add native support on iOS and Android for `Animated.diffClamp` that was added in react#9419.

**Test plan**
Tested that it works properly using the native animations UIExplorer example.
Closes react#9691

Differential Revision: D3813440

fbshipit-source-id: 48a3ecddf3708fa44b408954d3d8133ec8537f21
ide pushed a commit to expo/react-native that referenced this pull request Oct 27, 2016
@janicduplessis @ide
Add support for DiffClamp node
b87ba89 
Summary:
Add native support on iOS and Android for `Animated.diffClamp` that was added in react#9419.

**Test plan**
Tested that it works properly using the native animations UIExplorer example.
Closes react#9691

Differential Revision: D3813440

fbshipit-source-id: 48a3ecddf3708fa44b408954d3d8133ec8537f21
@facebook-github-bot facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janicduplessis @brentvatne @facebook-github-bot