Translate Implementation Notes#124
Merged
Merged
Conversation
96 tasks
|
Deploy preview for idreactjs ready! Built with commit 0043fa3 |
|
Deploy preview for id-reactjs ready! Built with commit 0043fa3 |
resir014
requested changes
Oct 30, 2019
resir014
left a comment
Member
There was a problem hiding this comment.
Thanks @tegarjgap! Here are my notes for the first half of the page. Will continue to read through later tonight.
change 'publik API' into 'API publik' Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic symbol on path source Co-Authored-By: Resi Respati <resir014@gmail.com>
Change subclasses into Subkelas Co-Authored-By: Resi Respati <resir014@gmail.com>
Change ambigous text Co-Authored-By: Resi Respati <resir014@gmail.com>
Change Element into Elemen Change misalnya into mis. Co-Authored-By: Resi Respati <resir014@gmail.com>
Change element into elemen Co-Authored-By: Resi Respati <resir014@gmail.com>
tjgeni
commented
Oct 31, 2019
resir014
requested changes
Nov 2, 2019
resir014
left a comment
Member
There was a problem hiding this comment.
Second pass. After this is done, everything should look good.
Change module name in React and fix capitalize Co-Authored-By: Resi Respati <resir014@gmail.com>
Change subclasses into Subkelas Co-Authored-By: Resi Respati <resir014@gmail.com>
Fix ambiguous text Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks and fix the grammar Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic in method name in code blocks Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks Co-Authored-By: Resi Respati <resir014@gmail.com>
change contained into dibungkus Co-Authored-By: Resi Respati <resir014@gmail.com>
fix capitalize text Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <resir014@gmail.com>
don't translate text 'key' Co-Authored-By: Resi Respati <resir014@gmail.com>
change sentence 'dari tutorial hidup ini' become 'dari tutorial ini berada' Co-Authored-By: Resi Respati <resir014@gmail.com>
tjgeni
commented
Nov 2, 2019
resir014
approved these changes
Nov 4, 2019
resir014
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for your help! 🎉
Contributor
Author
|
Alright, Thanks @resir014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.