Skip to content

[PSR4] Skip NormalizeNamespaceByPSR4ComposerAutoloadRector on has inline HTML #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Jul 10, 2021
Merged

[PSR4] Skip NormalizeNamespaceByPSR4ComposerAutoloadRector on has inline HTML #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d75137
[PSR4] Skip NormalizeNamespaceByPSR4ComposerAutoloadRector on has inl…
samsonasik Jul 10, 2021
c065015
fixture
samsonasik Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...Namespace/NormalizeNamespaceByPSR4ComposerAutoloadRector/Fixture/skip_inline_html.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<h1> {{ content }} </h1>
10 changes: 10 additions & 0 deletions rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use PhpParser\Node;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Declare_;
use PhpParser\Node\Stmt\InlineHTML;
use PhpParser\Node\Stmt\Namespace_;
use Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace;
use Rector\Core\Rector\AbstractRector;
Expand Down Expand Up @@ -80,6 +81,10 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}

$expectedNamespace = $this->psr4AutoloadNamespaceMatcher->getExpectedNamespace($this->file, $node);
if ($expectedNamespace === null) {
return null;
Expand All @@ -101,6 +106,11 @@ public function refactor(Node $node): ?Node
return $node;
}

private function shouldSkip(Node $node): bool
{
return (bool) $this->betterNodeFinder->findFirstInstanceOf($node, InlineHTML::class);
}

private function refactorFileWithoutNamespace(
FileWithoutNamespace $fileWithoutNamespace,
string $expectedNamespace
Expand Down