fix(homepage): use a single Home nav with page:homepage - #5039
Open
lokanandaprabhu wants to merge 3 commits into
Open
lokanandaprabhu wants to merge 3 commits into
lokanandaprabhu wants to merge 3 commits into
Conversation
Disable community page:home in the example app so NFS does not show two Home sidebar items when both plugins are present. Co-authored-by: Cursor <cursoragent@cursor.com>
lokanandaprabhu
requested review from
a team,
Eswaraiahsapram and
christoph-jerolimov
as code owners
September 29, 2026 15:23
Changed Packages
|
Drop the unused React import that broke tsc:full, disable the classic JSX-scope eslint rule in Sidebar, and remove the app-only changeset that incorrectly targeted the published homepage package. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
=======================================
Coverage 63.66% 63.66%
=======================================
Files 2708 2708
Lines 106621 106621
Branches 30060 30055 -5
=======================================
Hits 67882 67882
Misses 36911 36911
Partials 1828 1828
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Drop the one-off eslint-disable. With page:home: false in app-config,
nav.take('page:home') is a no-op and the sidebar still shows a single Home.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page:homein the homepage example app so NFS shows only RHpage:homepagein the sidebar.homepageHomeModulefrom the example app and stop takingpage:homein the sidebar (avoids two Home nav items when both plugins are present).Test plan
yarn startinworkspaces/homepageshows a single Home sidebar item/and loads the RH homepageapi:home/visits/ visit-listener enabledMade with Cursor