Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f4c460a2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5bd49fe67
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0783962ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ggregates` via implicit conversion)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12d36feded
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
# Conflicts: # Directory.Build.props # src/NRedisStack/Experiments.cs # src/NRedisStack/PublicAPI/PublicAPI.Unshipped.txt
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7480433a62
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed2a14759a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
in this PR:
[Flags] enumto subsume the multipleboolargsQueryLabelNames[Async]andQueryLabelValues[Async]TsAggregationsoverTsAggregation; can describe single-aggregations just fine(long,long)was used and(double,double)would have been preferable (non-integer values are normal and expected); old API retained, marked[Obsolete], hidden, and de-prioritizedRedisKey) errors, and ensure that the CI runs on standalone and cluster, at least for cluster 8.10+ (it is quirky before this!) - this also involved fixing some test expectations around ordering on non-key-routed commandsNote
Medium Risk
Large public API surface and overload/binary-compat layering; behavior changes on filterByValue and WITHLABELS could affect existing callers, though obsolete paths are preserved.
Overview
Adds Redis Time Series 8.10 client support: new commands and API refinements, with backward-compatible overloads and stronger test/CI coverage on cluster.
New commands:
QueryLabelNames/QueryLabelValues(TS.QUERYLABELS), pivot queriesNRange/NRevRange(TS.NRANGE/TS.NREVRANGE) returningTimeSeriesPivotRow, and non-blockingRead/ReadEnumerable(and async equivalents) forTS.READ—blocking mode is intentionally not exposed.Range API:
TimeSeriesRangeFlagsreplaces scatteredboolparameters onMRange/MRevRange(including EXCLUDEEMPTY).filterByValueis now(double, double)on range APIs; older(long, long)overloads remain for binary compat but are obsolete, hidden, and lower priority.AddWithLabelsonly treatswithLabels == trueas conflicting withselectLabels.Wire/protocol:
EXCLUDEEMPTYis emitted beforeFILTERon multi-range;BuildNRangeArgsshares aggregation validation with single-key range. Keys are cast toRedisKeywhere routing was wrong.Tests/CI: Cluster runs for more TS tests (hash-tagged keys, skips pre-8 / pre-8.10 for fan-out commands), order-insensitive assertions for keyless filter commands, version skip fix for
8.10vs8.10.0, and a compile-time guard so integer tuples bind to(double, double)not obsolete(long, long).Reviewed by Cursor Bugbot for commit 2828c99. Bugbot is set up for automated code reviews on this repo. Configure here.