feat(designer): run whole condition on arena + g6_io_bench demo - #129
Merged
Conversation
…st trialParams)
The inspector's per-condition arena button was a trialParams-only "dry-run"
(LAB-94) — it skipped waits, plugins, and the new setAnalogOut/setDigitalOut,
which was misleading now that the full-sequence runner (LAB-97) exists. Repurpose
it to run the WHOLE selected condition end-to-end.
- onRunConditionDryRun builds a one-step sequence for the selected condition and
runs it through the same runSequence path as "Run on arena" (waits, allOn/allOff,
setPositionX, setAnalogOut/setDigitalOut all replay; plugins skipped-with-warning).
Button relabeled "Run this condition".
- Extract runStepsOnArena() shared by onRunSequence + the per-condition run
(connect-on-demand + run + button re-sync in one place); drop the now-duplicate
connect block from onRunSequence.
- preRunCheck(opts) parameterized: { steps, hasRandom, title, body, confirmLabel }
scopes the confirm to one condition; no-arg = whole sequence.
- renderArenaTestControl shows the button for ANY condition with commands (dropped
the trialParams-only gate); updated notes/tooltips/comments.
- Footer v0.37 -> v0.38.
Reuses the hardware-verified runSequence path. Browser-verified: the button now
renders for a non-trialParams condition (arena_check), module loads clean, pixi
run test green. The whole-condition run is NOT yet exercised on hardware.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… SD) One-click AO/DO bench test in the "Load demo" dropdown: a pure-I/O condition (setDigitalOut + setAnalogOut + waits, NO trialParams) so it runs with no pattern/SD-card dependency — pairs with the new "Run this condition" button. - tests/fixtures/v3_g6_io_bench.yaml (new) - experiment_designer_v3.html: demo dropdown option; footer v0.38 -> v0.39 Browser-verified: demo loads (io_test + 6 commands), no console errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mbreiser
added a commit
that referenced
this pull request
Jul 2, 2026
* docs(arena-studio): unification design + wireframes v1–v5 + handover Consolidated onto current main. v5 is the approved density/ergonomics pass over v4 (one 44px bar; Console essentials + collapsible foot-gun groups; 150px collapsible run-log) with content re-synced to shipped main: ArenaSession broker shipped, run-log module built-but-unwired, plus #126 analog/digital-out, #129 run-whole-condition, #130 0x88 + panel-display-mode, #131 FicTrac. Handover refreshed to the verified 2026-07-01 shipped-vs-pending table. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * arena-studio: ISP firmware-push handoff + same-origin dev artifacts Groundwork for Arena Studio's "push official builds to panels" flow: - docs/development/arena-studio-isp-firmware-push-handoff.md — catalog schema (isp_file/isp_sha256, firmware repo PR #17), the 0xE0/0xE3/0xC8/ 0xC9 wire flow (encoders already in js/arena-wire-g6.js), UX notes from the real fleet reflash, gotchas (CORS: Pages yes / Release assets no). - flasher/firmware/manifest-dev.json — schema-identical dev catalog to develop against until PR #17 + a release tag publish the real one. - Dev builds (same-origin): isp-progress-display 23d66af (progress bar while ISP-flashing + first-boot smiley), both revs, .bin + .uf2; plus the current fleet build (dd7d3f9) ISP bins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #126 (G6
setAnalogOut/setDigitalOutprotocol commands + field validation, already merged). Two v3-designer changes:Feature A — per-condition run replays the whole condition (
83f822a)The inspector's per-condition button (was "Test on arena", trialParams-only) now runs the entire selected condition via the shared
runSequencepath — controller commands + waits, in order, plugins skipped-with-warning — instead of sending onlytrialParams. Relabeled "Run this condition"; eligibility relaxed to any condition with commands.preRunCheckis parameterizable; extractedrunStepsOnArena(steps, conditionsByName)shared by "Run on arena" (whole sequence) and "Run this condition" (single-condition step list).setAnalogOut/setDigitalOutI/O commands (logged in ROADMAP "To review").g6_io_benchbuilt-in demo (d4c2b41)One-click AO/DO bench test in Load demo ▾: a pure-I/O condition (
setDigitalOut+setAnalogOut+ waits, no trialParams, so no pattern/SD dependency). New fixturetests/fixtures/v3_g6_io_bench.yaml.Footer bumped to v0.39.
Verification
pixi run testgreen (v2 137, v3 663, wire 112, runner 130, plugin-registry 15, +others).🤖 Generated with Claude Code