Initial validate logic and tests#31
Merged
Merged
Conversation
leelynne
commented
Aug 15, 2025
| RequiredMetadata: []Metadata{MetaCreated, MetaKeyID}, | ||
| DisallowedMetadata: []Metadata{MetaAlgorithm}, // The algorithm should be looked up from the keyid not an explicit setting. | ||
| CreatedValidDuration: time.Minute * 5, // Signatures must have been created within within the last 5 minutes | ||
| DateFieldSkew: time.Minute, // If the created parameter is present, the Date header cannot be more than a minute off. |
Collaborator
Author
There was a problem hiding this comment.
I got rid of DateFieldSkew (it was never actually used for enforcement) as this is not part of the spec and is related to an http header and not a signature component.
harshita-chaudhary
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds logic to enforce the VerifyProfile settings - allowed algorithms, required metadata, timing related options, etc.