test/runtime: keep registry build type-safe and align BYOS health fallback - #48
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
reprewindai-dev
left a comment
There was a problem hiding this comment.
Exact-head reconciliation: this is a narrowly scoped test-only TypeScript correction on current main (7d01490403117bbbd4c69003f8861606a8a15473) and does not alter the CAPPO-only consequential-execution boundary. The patch is directionally safe: process.env is cast mutable only inside the registry test file, while the fail-closed production registry-token cases remain intact.
Do not merge yet. GitHub Actions run 31754008879 for exact head 9fa832abf54badebcf04ab6cdda3ad2e534d3656 concluded failure; its only verify job (94625777060) has no executable step payload, matching the current repository Actions-execution outage. The PR body's local npm test / npm run build results are useful source evidence but are not an independently executed exact-head gate.
Before readiness: restore executable exact-head CI, require test + production build/typecheck to pass there, and reconcile this build fix into the eventual #44 fail-closed authority branch/rebase so we do not create two competing cAPI baselines. Runtime remains NOT_VERIFIED; no deployment claim follows from this test-only patch.
reprewindai-dev
left a comment
There was a problem hiding this comment.
Exact-head reconciliation: this PR is no longer test-only. In addition to the NODE_ENV typing fix, it changes production dependency probing for the BYOS MCP gateway fallback from /api/v1/health to /health and updates its test. That runtime behavior change is directionally consistent with the canonical BYOS shallow health contract, but the PR title/body must describe it explicitly so this cannot be mistaken for a no-runtime-behavior test cleanup. Keep draft until the scope is corrected and exact-head test/build/typecheck/security gates actually execute. Current cAPI CI run 31810999485 failed pre-execution (steps: [], no assigned runner), so there is still no executable CI evidence for this head. No runtime verification claim.
Objective
Keep the canonical cAPI production build type-safe while explicitly aligning the BYOS dependency-health fallback with BYOS's canonical shallow health contract.
Changes
process.envas a mutable record only inside registry tests so production TypeScript compilation remains clean./api/v1/healthto canonical shallow/health.http://byos:8088/health.This PR therefore does include a small production runtime behavior change in dependency probing; it is not test-only.
Verification
Branch-reported local verification:
npm test: 17 files, 60 tests passed.npm run build: production compilation and TypeScript completed successfully.These local results are not a substitute for executable exact-head GitHub Actions.
Runtime truth boundary
observed_current_responsibilities: cAPI performs dependency probing and remains the canonical Interlink; BYOS exposes the shallow process-health contract at/health.reported_runtime_state: cAPI3003, BYOS8088.verified_runtime_state:NOT_VERIFIEDfor both; this PR does not establish deployed SHA, HTTP/protocol identity, container listener, or Traefik routing.Keep draft until exact-head test/build/typecheck/security/dependency checks actually execute and pass with no blocking review.