Skip to content

Enforce completion owners for public type aliases - #350

Draft
jderochervlk wants to merge 3 commits into
mainfrom
agent/complete-from-aliases
Draft

Enforce completion owners for public type aliases#350
jderochervlk wants to merge 3 commits into
mainfrom
agent/complete-from-aliases

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • validate that public Foo.t aliases have @editor.completeFrom(Foo) on their internal backing types
  • correct the existing completion owners and the Element.Impl.setAttributeNS receiver type
  • add compile-time coverage for recursive DOM aliases and inherited element methods

Why

Public modules expose internal record types through aliases. Several backing types either had a stale completion owner or no annotation, so editor completions could point at the internal module instead of the public API. The feature validator now enforces this relationship for future aliases while excluding intentional public-to-public t aliases.

This addresses the first follow-up item in #342.

Validation

  • npm run build
  • npm run check:features
  • npm test
  • npm run format:check
  • git diff --check

@jderochervlk jderochervlk changed the title Enforce completion owners for type aliases Enforce completion owners for public type aliases Aug 29, 2026
@jderochervlk

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T14:56:25.399393Z 6d908bf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d908bf20e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check-features.mjs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant