caml_int64_format support, clean up the implementation next revision - #203
Merged
Conversation
EduardoRFS
pushed a commit
to EduardoRFS/bucklescript
that referenced
this pull request
Mar 11, 2022
JonoPrest
added a commit
to JonoPrest/rescript-compiler
that referenced
this pull request
Jun 11, 2026
…ability blocker Two findings from triaging the DCE output: 1. Roots: a plain `dune build` emits only .cmti for modules with an .mli (incl the bsc main), so reanalyze missed the entry-point bodies and over-reported. Switch the runner to `dune build @check`, which emits impl .cmt for every module. Fixes the Bs_version-class false positives (Dead Value ~2740->2130, Dead Module ~203->146). 2. Blocker: even with roots fixed, reanalyze#203 flags obviously-live core modules as dead (Ast_helper has 510 in-tree refs; Lam_compile, Js_dump, Lam_convert likewise). Per the PR, its 5.3 value-dependency tracking is derived 'just based on the type' in cmt_infos and is incomplete (rescript-lang/reanalyze#202). So cross-reference-based categories aren't trustworthy yet. Documented in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fix a minor bug when escaping
(%)