polymorphic suggestion for unhandled cases in switch uses backtick

[Coobaha]

let withpayload = #polymorphic(3)
switch withpayload {
  | #polymoprhic(c) => Js.log(c)
}

 13 │ 
  14 │ let withpayload = #polymorphic(3)
  15 │ switch withpayload {
  16 │   | #polymoprhic(c) => Js.log(c)
  17 │ }
  18 │ 
  19 │ let array = [1,2,3]
  
  You forgot to handle a possible case here, for example: 
`polymorphic _

[Coobaha]

I should have opened this in bs-platform directly maybe.. cc @bobzhang

[chenglou]

Just to make sure: you saw that you made a typo right?
And yeah this isn't syntax-related =). Thanks. Closing!

[Coobaha]

Oh yeah 😅 error suggested case uses ` instead of #

[chenglou]

Whoops my mistake. That's a printing error.

[cristianoc]

Could be, this is about warnings (wrong syntax) vs errors (correct syntax). Unless there's another repro with errors.
CC @bobzhang

[Coobaha]

Another old issue with suggestions that exists in .re is that suggestions are printed in .ml syntax.

type myT =
  | A
  | B
  | C
  | D(int)

switch (A) {
  | A => 1
}

  26 │ switch (A) {
  27 │   | A => 1
  28 │ }
  29 │ 
  30 │ let array = [1,2,3]
  
  You forgot to handle a possible case here, for example: 
(B|C|D _)

[bobzhang]

This is a long existing issue (with refmt too), seems we need to patch
val Parmatch.pretty_val : Format.formatter -> Typedtree.pattern -> unit
cc @cristianoc @IwanKaramazow

[bobzhang]

Note there's an easy solution:

We can convert Typedtree.pattern to Parsetree.pattern
pat: mapper -> Typedtree.pattern -> pattern;
So that if res gives us a printer for Parsetree.pattern, it should work

[stale]

The rescript-lang/syntax repo is obsolete and will be archived soon. If this issue is still relevant, please reopen in the compiler repo (https://github.com/rescript-lang/rescript-compiler) or comment here to ask for it to be moved. Thank you for your contributions.