Skip to content

feat(webhooks): add signing secret rotation endpoint - #141

Merged
kewynakshlley merged 3 commits into
mainfrom
feat/webhook-signing-secret-rotation
Sep 10, 2026
Merged

kewynakshlley merged 3 commits into
mainfrom
feat/webhook-signing-secret-rotation

Conversation

@gabrielmfern

@gabrielmfern gabrielmfern commented Sep 9, 2026

Copy link
Copy Markdown
Member

This adds resend.webhooks().rotateSigningSecret(webhookId) for POST /webhooks/{webhook_id}/signing-secret/rotate, mirroring the event replay method. The response model carries object, id, and signing_secret, the same shape create webhook already returns.

Spec: resend/resend-openapi#113
Linear: https://linear.app/resend/issue/DEV-2079

🤖 Generated with Claude Code


Summary by cubic

Adds a new endpoint to rotate a webhook's signing secret. This lets users replace a compromised secret without recreating the webhook; the previous secret keeps working for 24 hours after rotation.

  • Implements the signing secret rotation endpoint from DEV-2079, matching the existing replay event method and returning the same response shape as create webhook.
  • Bumps the package version to 4.24.0.

Written for commit c4faa31. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
klotty
klotty previously approved these changes Sep 9, 2026

@klotty klotty left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Adds a new webhook signing-secret rotation endpoint and response model, mirroring the existing replay method, with a test covering the new call.

Re-trigger cubic

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds a new webhook signing-secret rotation method and response model, expanding the SDK's public API surface with a new endpoint that needs human contract review.

Re-trigger cubic

}

/**
* Rotates the signing secret of a webhook. The previous secret stops verifying immediately.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't invalidated immediately, there's a 24-hour grace

…ing secret

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds a new public webhook signing-secret rotation endpoint and response model, expanding the SDK's API surface; a human should review the endpoint design and response shape before release.

Re-trigger cubic

@kewynakshlley
kewynakshlley merged commit 6fcb7ab into main Sep 10, 2026
4 checks passed
@kewynakshlley
kewynakshlley deleted the feat/webhook-signing-secret-rotation branch September 10, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants