Skip to content

chore: unpin flake8 so lint runs on Python 3.14 - #284

Merged
felipefreitag merged 1 commit into
mainfrom
chore/unpin-flake8
Sep 15, 2026
Merged

felipefreitag merged 1 commit into
mainfrom
chore/unpin-flake8

Conversation

@felipefreitag

@felipefreitag felipefreitag commented Sep 15, 2026

Copy link
Copy Markdown
Member

Maintainers can release from the Release workflow again after Renovate moved it to Python 3.14.

Before, the lint step crashed on Python 3.14 before it read a single file, because the lint env held flake8 at version 4. The first tag-triggered release, v2.45.1, stopped there and nothing reached PyPI. The tests workflow kept passing because its matrix ends at 3.11, so the problem only showed on a release.

Now the lint env installs the current flake8, which runs on 3.14 and reports no findings on the current code. Mypy and the test suite already pass on 3.14.

How to reach it. Merge, then re-tag 2.45.1 on the new main head and push the tag. The Release run should go green through publish.

Not covered. The tests workflow still runs Python 3.8 to 3.11 only. The next runtime bump by Renovate on the release workflow will again run checks on a version the matrix does not cover.


Summary by cubic

Unpins flake8 in the lint env so lint passes on Python 3.14 again. Lint previously crashed before reading a file because flake8 4 relied on an importlib.metadata API that Python 3.14 removed, which stopped the tag-triggered release at v2.45.1 before anything reached PyPI.

Now the lint env installs the current flake8, which runs on 3.14 and reports no findings on the current code. After merging, re-tag v2.45.1 on the new main head and push the tag so the Release workflow completes through publish. The tests workflow still runs Python 3.8–3.11 only, so future runtime bumps may hit gaps not covered by the matrix.

Written for commit 61cd069. Summary will update on new commits.

Review in cubic

flake8 4 uses an importlib.metadata API that Python 3.14 removed, so
the lint env crashed before it read a file once the release workflow
moved to 3.14. flake8 7.3.0 runs on 3.14 and reports no findings on
the current code.

@klotty klotty left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Unpins flake8 in the lint env so lint runs on Python 3.14 and the release workflow can complete; dev-only dependency fix with no runtime code change.

Re-trigger cubic

@felipefreitag
felipefreitag merged commit 23bc415 into main Sep 15, 2026
23 checks passed
@felipefreitag
felipefreitag deleted the chore/unpin-flake8 branch September 15, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants