Skip to content

Add User Agent without validation. - #1973

Merged
alexeyzimarev merged 1 commit into
restsharp:devfrom
alekw:feature/alekw/UserAgentWithoutValidation
Nov 18, 2022
Merged

Add User Agent without validation.#1973
alexeyzimarev merged 1 commit into
restsharp:devfrom
alekw:feature/alekw/UserAgentWithoutValidation

Conversation

@alekw

@alekw alekw commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Description

Add User Agent without validation. It will allow usage of any string as User Agent. Useful for imitating other user agents.
Previous implementation has forbidden multiple characters, which are used in other http clients (not only .net).

#1943
#1905

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dnfadmin

dnfadmin commented Nov 17, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@alexeyzimarev

Copy link
Copy Markdown
Member

Thank you for the PR. Please remember to sign the CLA.

@alekw

alekw commented Nov 18, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the PR. Please remember to sign the CLA.

Yesterday I had some problems with signing CLA, today I have managed.

@alexeyzimarev
alexeyzimarev merged commit 28b5478 into restsharp:dev Nov 18, 2022
@alekw
alekw deleted the feature/alekw/UserAgentWithoutValidation branch November 18, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants