Documentation fixes - #2002
Closed
EdLichtman wants to merge 13 commits into
Closed
Conversation
… pretty fatal so you would not want this to silently show up in the Exception response value. (restsharp#1967)
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.1.2 to 3.2.0. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits/v3.2.0) --- updated-dependencies: - dependency-name: coverlet.collector dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [JetBrains.Annotations](https://github.com/JetBrains/JetBrains.Annotations) from 2022.1.0 to 2022.3.1. - [Release notes](https://github.com/JetBrains/JetBrains.Annotations/releases) - [Commits](https://github.com/JetBrains/JetBrains.Annotations/commits) --- updated-dependencies: - dependency-name: JetBrains.Annotations dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 13.0.1 to 13.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@13.0.1...13.0.2) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds more Parameter Tests
|
|
tacosontitan
approved these changes
Feb 21, 2023
tacosontitan
left a comment
Contributor
There was a problem hiding this comment.
Overall, this looks like a solid contribution to the documentation for the library.
Member
|
Would you be able to make this PR targeting the |
Contributor
Author
|
Hrm... It seems I may need to pull latest v109, otherwise I may be including commits and changes that you guys aren't ready to put into v109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some misleading documentation (ParameterType.GetOrPost was suggesting that it was a Cookie Parameter, and UrlSegmentParameter suggested it modifies the Query String) and adds additional documentation (adds information to the ResponseStatus to explain what each Response Status means).
Also, adds tests to ensure UrlSegment operates properly and as an enhanced form of documentation for users looking into this code.
Purpose
This pull request is a:
Checklist